Re: [patch] mailbox/omap: make mbox->irq signed for error handling

2013-11-11 Thread Suman Anna
On 11/07/2013 01:49 AM, Dan Carpenter wrote: There is a bug in omap2_mbox_probe() where we try do: mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) { The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed

[patch] mailbox/omap: make mbox->irq signed for error handling

2013-11-06 Thread Dan Carpenter
There is a bug in omap2_mbox_probe() where we try do: mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) { The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer. Signed-off-by: Dan Carp