Re: [patch] lockdep: more unlock-on-error fixes, fix

2006-12-19 Thread Jarek Poplawski
On Tue, Dec 19, 2006 at 10:50:47AM +0100, Ingo Molnar wrote: ... > moving the graph unlock back, and by leaving the max_lockdep_depth > variable update possibly racy. (we dont care, it's just statistics) I would agree if it were not the lockdep. I mean it's like the "father figure"! > also add so

[patch] lockdep: more unlock-on-error fixes, fix

2006-12-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > An updated patch is below. I also have boot tested it. Andrew, Linus, > please apply. this patch introduced a locking bug, which is fixed by the delta patch below. Ingo > Subject: [patch] lockdep:

Re: [patch] lockdep: more unlock-on-error fixes

2006-12-18 Thread Jarek Poplawski
On Mon, Dec 18, 2006 at 03:39:36PM +0100, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > If any of this proposals should be omitted or separated let me know. > > thanks for the fixes, they look good to me. I have reorganized the > __lock_acquire() chan

[patch] lockdep: more unlock-on-error fixes

2006-12-18 Thread Ingo Molnar
t; Subject: [patch] lockdep: more unlock-on-error fixes From: Jarek Poplawski <[EMAIL PROTECTED]> - returns after DEBUG_LOCKS_WARN_ON added in 3 places - debug_locks checking after lookup_chain_cache() added in __lock_acquire() - locking for testing and changing global variable ma