Re: [patch] implement smarter atime updates support, v2

2007-08-05 Thread Ingo Molnar
* Theodore Tso <[EMAIL PROTECTED]> wrote: > On Sun, Aug 05, 2007 at 09:28:38PM +0200, Ingo Molnar wrote: > > > > added the relatime_interval sysctl that allows the changing of the > > atime update frequency. (default: 1 day / 86400 seconds) > > What if you specify the interval as a per-mount o

Re: [patch] implement smarter atime updates support, v2

2007-08-05 Thread Theodore Tso
On Sun, Aug 05, 2007 at 09:28:38PM +0200, Ingo Molnar wrote: > > added the relatime_interval sysctl that allows the changing of the atime > update frequency. (default: 1 day / 86400 seconds) What if you specify the interval as a per-mount option? i.e., mount -o relatime=86400 /dev/sda

Re: [patch] implement smarter atime updates support

2007-08-05 Thread Arjan van de Ven
On Sun, 2007-08-05 at 21:04 +0100, Alan Cox wrote: > O> you might want to add > > > > /* > > * if the inode is dirty already, do the atime update since > > * we'll be doing the disk IO anyway to clean the inode. > > */ > > if (inode->i_state & I_DIRTY) > > retur

Re: [patch] implement smarter atime updates support

2007-08-05 Thread Alan Cox
O> you might want to add > > /* >* if the inode is dirty already, do the atime update since >* we'll be doing the disk IO anyway to clean the inode. >*/ > if (inode->i_state & I_DIRTY) > return 1; This makes the actual result somewhat less predic

Re: [patch] implement smarter atime updates support

2007-08-05 Thread Arjan van de Ven
> +static int relatime_need_update(struct inode *inode, struct timespec now) > +{ > + /* > + * Is mtime younger than atime? If yes, update atime: > + */ > + if (timespec_compare(&inode->i_mtime, &inode->i_atime) >= 0) > + return 1; > + /* > + * Is ctime young

[patch] implement smarter atime updates support, v2

2007-08-05 Thread Ingo Molnar
new version: added the relatime_interval sysctl that allows the changing of the atime update frequency. (default: 1 day / 86400 seconds) Ingo --> Subject: [patch] [patch] implement smarter atime updates support From: Ingo Molnar <[EMAIL PROTECTED]>

[patch] implement smarter atime updates support

2007-08-05 Thread Ingo Molnar
ent boot option and all the switches (be that config, boot or sysctl) are now called "default_relatime". Also, got rid of that #ifdef ugliness in namespace.c via a cleaner Kconfig solution (suggested by Peter Zijlstra). Ingo --------> Subject: [patch]