On Mon 13-08-12 20:10:41, Hillf Danton wrote:
> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko wrote:
> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko
> > Date: Fri, 10 Aug 2012 15:03:07 +0200
> > Subject: [PATCH] hugetlb: do not use vma_hugecache_o
On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko wrote:
> From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001
> From: Michal Hocko
> Date: Fri, 10 Aug 2012 15:03:07 +0200
> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
> vma_prio_tree_foreach
>
> 0c176d5 (mm: huge
On Sun 12-08-12 12:08:21, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 9:48 PM, Michal Hocko wrote:
>
> > It's been compile tested because it only restores the previous code with
> > a simple and obvious bug fix.
>
> It helps more if you elaborate on such a simple and obvious bug and
> enrich y
On Fri, Aug 10, 2012 at 9:48 PM, Michal Hocko wrote:
> It's been compile tested because it only restores the previous code with
> a simple and obvious bug fix.
It helps more if you elaborate on such a simple and obvious bug and
enrich your change log accordingly?
--
To unsubscribe from this list
On Fri 10-08-12 21:21:15, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko wrote:
> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
> > vma_prio_tree_foreach
> >
> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
> > from vma) fixed pgoff calcul
On Fri, Aug 10, 2012 at 9:21 PM, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko wrote:
>> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
>> vma_prio_tree_foreach
>>
>> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
>> from vma) fixed pgoff cal
On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko wrote:
> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
> vma_prio_tree_foreach
>
> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
> from vma) fixed pgoff calculation but it has replaced it by
> vma_hugecache_offset whi
[CCing Kamezawa and David]
On Fri 10-08-12 20:53:36, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 8:51 PM, Michal Hocko wrote:
> > On Fri 10-08-12 20:37:20, Hillf Danton wrote:
> >> On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko wrote:
> >> >
> >> > I guess you mean unmap_ref_private and that ha
On Fri, Aug 10, 2012 at 8:51 PM, Michal Hocko wrote:
> On Fri 10-08-12 20:37:20, Hillf Danton wrote:
>> On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko wrote:
>> >
>> > I guess you mean unmap_ref_private and that has been changed by you
>> > (0c176d5 mm: hugetlb: fix pgoff computation when unmappin
On Fri 10-08-12 20:37:20, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko wrote:
> >
> > I guess you mean unmap_ref_private and that has been changed by you
> > (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from
> > vma)... I was wrong at that time when givin
On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko wrote:
>
> I guess you mean unmap_ref_private and that has been changed by you
> (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from
> vma)... I was wrong at that time when giving my Reviewed-by. The patch
> didn't break anything beca
On Fri 10-08-12 20:07:12, Hillf Danton wrote:
> On Fri, Aug 10, 2012 at 5:48 PM, Michal Hocko wrote:
> > On Fri 03-08-12 15:32:35, Michal Hocko wrote:
> >> On Fri 03-08-12 20:56:45, Hillf Danton wrote:
> >> > The computation of page offset index is open coded, and incorrect, to
> >> > be used in s
On Fri, Aug 10, 2012 at 5:48 PM, Michal Hocko wrote:
> On Fri 03-08-12 15:32:35, Michal Hocko wrote:
>> On Fri 03-08-12 20:56:45, Hillf Danton wrote:
>> > The computation of page offset index is open coded, and incorrect, to
>> > be used in scanning prio tree, as huge page offset is required, and
On Fri 03-08-12 15:32:35, Michal Hocko wrote:
> On Fri 03-08-12 20:56:45, Hillf Danton wrote:
> > The computation of page offset index is open coded, and incorrect, to
> > be used in scanning prio tree, as huge page offset is required, and is
> > fixed with the well defined routine.
>
> I guess th
On Fri 03-08-12 20:56:45, Hillf Danton wrote:
> The computation of page offset index is open coded, and incorrect, to
> be used in scanning prio tree, as huge page offset is required, and is
> fixed with the well defined routine.
I guess that nobody reported this because if someone really wants to
The computation of page offset index is open coded, and incorrect, to
be used in scanning prio tree, as huge page offset is required, and is
fixed with the well defined routine.
Signed-off-by: Hillf Danton
---
--- a/arch/x86/mm/hugetlbpage.c Fri Aug 3 20:34:58 2012
+++ b/arch/x86/mm/hugetlbpage
16 matches
Mail list logo
