Re: [patch] export hrtimer_forward

2007-05-04 Thread Thomas Gleixner
On Thu, 2007-05-03 at 16:58 -0700, Andrew Morton wrote: > It was probably an oversight - generally we take the position that all the > formal interface of a subsystem is exported to modules rather than a > piecemeal whichever-bits-kernel.org-happens-to-use-today approach. > > Thomas, is hrtimer_fo

Re: [patch] export hrtimer_forward

2007-05-03 Thread Andrew Morton
On Thu, 03 May 2007 23:10:02 +0400 Stas Sergeev <[EMAIL PROTECTED]> wrote: > Hello. > > Peter Zijlstra wrote: > >> It seems hrtimer_forward was forgotten to > >> export - other symbols of the hrtimers API > > Are there actual in-tree users of this symbol? Without we usually leave > > the symbol u

Re: [patch] export hrtimer_forward

2007-05-03 Thread Stas Sergeev
Hello. Peter Zijlstra wrote: It seems hrtimer_forward was forgotten to export - other symbols of the hrtimers API Are there actual in-tree users of this symbol? Without we usually leave the symbol unexported, this saves some space. Do you mean it was really left intentional? Unbeleivable! But

Re: [patch] export hrtimer_forward

2007-05-03 Thread Peter Zijlstra
On Thu, 2007-05-03 at 21:57 +0400, Stas Sergeev wrote: > Hello. > > It seems hrtimer_forward was forgotten to > export - other symbols of the hrtimers API > are already exported. > Unless I am missing something, using the > hrtimers without that function is problematic. > > Andrew, could you plea

[patch] export hrtimer_forward

2007-05-03 Thread Stas Sergeev
Hello. It seems hrtimer_forward was forgotten to export - other symbols of the hrtimers API are already exported. Unless I am missing something, using the hrtimers without that function is problematic. Andrew, could you please apply? Signed-off-by: <[EMAIL PROTECTED]> --- a/kernel/hrtimer.c 20