Re: [patch] ess maestro, support for hardware volume control

2001-06-12 Thread Lukas Schroeder
the little patch below (vs. 2.4.5-ac13) fixes a freeze which happens when the maestro module was unloaded and a HWV button gets pushed generating the interrupt. so this disables all irqs of that chip on remove... regards, lukas --- linux-2.4.5-ac13/drivers/sound/maestro.cTue Jun 12 13:

Re: [patch] ess maestro, support for hardware volume control

2001-06-10 Thread Abramo Bagnara
Zach Brown wrote: > > > I now have a patch that will output the hwv buttons pressed (up, > > down, mute) to a new dynamically allocated misc device as letters > > u, d, m, instead of directly modifying the mixer. Anyone want > > that? It's more flexible than either the patch that's currently >

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Alan Cox
> BTW, what is the officially approved way to open a device on a > dynamic misc minor? Reading /proc/misc for the minor number, Ask for minor 0 I believe, then load the module then see what you got. > then mknod'ing a device and opening it seems to me to have a > nasty race condition, am I miss

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Zach Brown
> I now have a patch that will output the hwv buttons pressed (up, > down, mute) to a new dynamically allocated misc device as letters > u, d, m, instead of directly modifying the mixer. Anyone want > that? It's more flexible than either the patch that's currently > in -ac or Lukas's patch, but

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Ben Pfaff
Alan Cox <[EMAIL PROTECTED]> writes: > > this patch applies to (at least) 2.4.3 up to and including 2.4.6-pre2. > > It enables the hardware volume control feature of the maestro. > > it doesnt apply to the current version of the maestro driver (2.4.5-ac) > however. I think it is clashing with t

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Alan Cox
> this patch applies to (at least) 2.4.3 up to and including 2.4.6-pre2. > It enables the hardware volume control feature of the maestro. it doesnt apply to the current version of the maestro driver (2.4.5-ac) however. I think it is clashing with the docking station support - To unsubscribe from

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Zach Brown
> below is the version with the suggested fixes, and with s/hwv/hwvol/ for > hwv_input also. fantastic, thanks lukas. alan, can you throw this in -ac? I don't think it will cause problems for people with nonstandard wiring on the hw vol pins (read: dell lattitudes), but if it does we can blackl

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Lukas Schroeder
> > By giving hwv=0 to insmod one can explicitly disable it. Setting > > can we have a better name like 'hwvol_enable'? > > > + set_mixer(c, 0, val); > > careful. you just used the indirect ac97 registers without holding the > card's lock.. if another processor does a mixer ioctl w

Re: [patch] ess maestro, support for hardware volume control

2001-06-09 Thread Zach Brown
> this patch applies to (at least) 2.4.3 up to and including 2.4.6-pre2. > It enables the hardware volume control feature of the maestro. cool. I had support for this in the mega-patch I posted long ago, but I never seperated and submitted those changes 'cause I'm a moron. > By giving hwv=0 to

[patch] ess maestro, support for hardware volume control

2001-06-09 Thread Lukas Schroeder
Hi, this patch applies to (at least) 2.4.3 up to and including 2.4.6-pre2. It enables the hardware volume control feature of the maestro. By giving hwv=0 to insmod one can explicitly disable it. Setting hwv_input=1 requests the alternative HWV input pins to be used. The maestro will generate in