Re: [patch] ata: ahci: Enclosure Management via LED

2007-12-07 Thread Pavel Machek
Hi! > > +static int ahci_em_messages = 1; > +module_param(ahci_em_messages, int, 0444); > +/* add other LED protocol types when they become supported */ > +MODULE_PARM_DESC(ahci_em_messages, > + "Set AHCI Enclosure Management Message type (0 = disabled, 1 = LED"); Should you add line in Doc

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > Enclosure Management via LED > > > > This patch implements Enclosure Management via the LED protocol as > > specified in AHCI specification. > > > > Signed-off-by: Kristen Carlson Accar

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-01 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- This revision makes the change to the comment requested by Mark Lord, fi

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-11-30 Thread Kristen Carlson Accardi
Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- This revision makes the change to the comment requested by Mark Lord, fixes some bugs in the bit shifting

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Ok, here's one that actually compiles... drivers/ata/ahci.c| 154 - drivers/ata

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Mark Lord
Kristen Carlson Accardi wrote: On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Kristen wrote: ... +* XXX will need Port Multiplier support What's that all about ? I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't impleme

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Kristen wrote: > ... > >+ * XXX will need Port Multiplier support > > What's that all about ? > I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't implement port multiplier support

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 09:48:02 -0800 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > This patch implements Enclosure Management via the LED protocol. See > the AHCI 1.1 spec for details. Whoops, I totally messed up and sent the wrong version of this patch. I'll send an updated one, ignore thi

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Mark Lord
Kristen wrote: ... +* XXX will need Port Multiplier support What's that all about ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Here's a new version of the Enclosure management patch I sent a few weeks ago. I tried to incorporate all the feedback, although I'm