Re: [patch] 2.4.2 Advantech WDT driver

Marek Michalkiewicz wrote: > > > Why is lock_kernel necessary? > > Well, it is there in 2.4.2 acquirewdt.c (which this driver is based on - > really only minimal changes, the hardware is only slightly different). > I can remove it if you tell me it's really not necessary. Sounds like it got cau

Re: [patch] 2.4.2 Advantech WDT driver

> Why is lock_kernel necessary? Well, it is there in 2.4.2 acquirewdt.c (which this driver is based on - really only minimal changes, the hardware is only slightly different). I can remove it if you tell me it's really not necessary. > > + spin_lock_init(&advwdt_lock); > > + misc_reg

Re: [patch] 2.4.2 Advantech WDT driver

Marek Michalkiewicz wrote: > +static int > +advwdt_close(struct inode *inode, struct file *file) > +{ > + lock_kernel(); > + if (MINOR(inode->i_rdev) == WATCHDOG_MINOR) { > + spin_lock(&advwdt_lock); > +#ifndef CONFIG_WATCHDOG_NOWAYOUT > + inb_p(WDT_STOP); >

[patch] 2.4.2 Advantech WDT driver

This patch adds the Advantech WDT driver (ported from 2.2.19pre, only minimal changes) to the 2.4.2 kernel. Please Cc: any replies to me (I'm not subscribed to linux-kernel). Thanks, Marek diff -urN v2.4.2/linux/drivers/char/Config.in linux/drivers/char/Config.in --- v2.4.2/linux/drivers/char/C