Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 10:48 -0400, Douglas Gilbert wrote: > On 13-03-11 09:10 AM, Dan Carpenter wrote: > > On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: > >> On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > >>> On 13-03-08 07:02 AM, Dan Carpenter wrote: > Static c

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread Douglas Gilbert
On 13-03-11 09:10 AM, Dan Carpenter wrote: On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: On 13-03-08 07:02 AM, Dan Carpenter wrote: Static checkers complain that this allocation isn't checked. We should return zero i

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread Dan Carpenter
On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: > On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > > On 13-03-08 07:02 AM, Dan Carpenter wrote: > > > Static checkers complain that this allocation isn't checked. We > > > should return zero if the allocation fails. > > >

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread Douglas Gilbert
On 13-03-08 05:50 PM, James Bottomley wrote: On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: On 13-03-08 07:02 AM, Dan Carpenter wrote: Static checkers complain that this allocation isn't checked. We should return zero if the allocation fails. Signed-off-by: Dan Carpenter diff --g

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread James Bottomley
On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > On 13-03-08 07:02 AM, Dan Carpenter wrote: > > Static checkers complain that this allocation isn't checked. We > > should return zero if the allocation fails. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/scsi/scsi_tr

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread Dan Carpenter
On Fri, Mar 08, 2013 at 12:57:12PM -0500, Douglas Gilbert wrote: > On 13-03-08 07:02 AM, Dan Carpenter wrote: > > For 32 bytes, why not use the stack? > It's a good point. I'll resend on Monday. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread Douglas Gilbert
On 13-03-08 07:02 AM, Dan Carpenter wrote: Static checkers complain that this allocation isn't checked. We should return zero if the allocation fails. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 1b68142..a022997 100644

[patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-08 Thread Dan Carpenter
Static checkers complain that this allocation isn't checked. We should return zero if the allocation fails. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 1b68142..a022997 100644 --- a/drivers/scsi/scsi_transport_sas.c +++