Re: [net PATCH v1 1/2] net: netprio: fix files lock and remove useless d_path bits

2012-08-13 Thread John Fastabend
On 8/13/2012 7:29 PM, Al Viro wrote: On Mon, Aug 13, 2012 at 06:39:39PM -0700, John Fastabend wrote: - path = d_path(&file->f_path, tmp, PAGE_SIZE); What's using tmp after that patch and do you still need to bother allocating it? nothing removed it in v2. -- To unsubsc

Re: [net PATCH v1 1/2] net: netprio: fix files lock and remove useless d_path bits

2012-08-13 Thread Al Viro
On Mon, Aug 13, 2012 at 06:39:39PM -0700, John Fastabend wrote: > - path = d_path(&file->f_path, tmp, PAGE_SIZE); What's using tmp after that patch and do you still need to bother allocating it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

[net PATCH v1 1/2] net: netprio: fix files lock and remove useless d_path bits

2012-08-13 Thread John Fastabend
Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected against is in fact handled correctly by sock_from_file as pointed out by Al Viro. CC: Neil Horman Reported-by: Al Viro Signed-off-by: