Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-03 Thread Vladimir Oltean
On Mon, Dec 02, 2024 at 10:29:31PM +0100, Christian Marangi wrote: > > Also I just notice msend suffer the very same problem... > > > > root@OpenWrt:~# ip vrf exec vlan1 msend -g ff2e::0102:0304 -I lan1 -c 1 > > Now sending to multicast group: [ff2e::0102:0304]: > > sendto: Address family not

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Mon, Dec 02, 2024 at 11:24:29PM +0200, Vladimir Oltean wrote: > On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > > Mhh the problem seems to be -c > > > > Let me post some outputs... > > > > root@OpenWrt:~# ping -V > > ping from iputils 20240117 > > libcap: no, IDN: no, NLS

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Mon, Dec 02, 2024 at 10:28:16PM +0100, Christian Marangi wrote: > On Mon, Dec 02, 2024 at 11:24:29PM +0200, Vladimir Oltean wrote: > > On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > > > Mhh the problem seems to be -c > > > > > > Let me post some outputs... > > > > > > ro

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Vladimir Oltean
On Mon, Dec 02, 2024 at 09:39:15PM +0100, Christian Marangi wrote: > Mhh the problem seems to be -c > > Let me post some outputs... > > root@OpenWrt:~# ping -V > ping from iputils 20240117 > libcap: no, IDN: no, NLS: no, error.h: no, getrandom(): yes, __fpending(): yes > root@OpenWrt:~# ping -c

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-12-02 Thread Christian Marangi
On Sat, Nov 30, 2024 at 05:48:40PM +0200, Vladimir Oltean wrote: > On Sat, Nov 30, 2024 at 04:46:14PM +0100, Christian Marangi wrote: > > On Sat, Nov 30, 2024 at 05:43:07PM +0200, Vladimir Oltean wrote: > > > On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > > > > If the coreutil

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-11-30 Thread Vladimir Oltean
On Sat, Nov 30, 2024 at 04:46:14PM +0100, Christian Marangi wrote: > On Sat, Nov 30, 2024 at 05:43:07PM +0200, Vladimir Oltean wrote: > > On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > > > If the coreutils variant of ping is used instead of the busybox one, the > > > ping_do()

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-11-30 Thread Christian Marangi
On Sat, Nov 30, 2024 at 05:43:07PM +0200, Vladimir Oltean wrote: > On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > > If the coreutils variant of ping is used instead of the busybox one, the > > ping_do() command is broken. This comes by the fact that for coreutils > > ping, the

Re: [net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-11-30 Thread Vladimir Oltean
On Sat, Nov 30, 2024 at 12:33:09PM +0100, Christian Marangi wrote: > If the coreutils variant of ping is used instead of the busybox one, the > ping_do() command is broken. This comes by the fact that for coreutils > ping, the ping IP needs to be the very last elements. > > To handle this, reorder

[net PATCH 1/2] selftests: net: lib: fix broken ping with coreutils ping util

2024-11-30 Thread Christian Marangi
If the coreutils variant of ping is used instead of the busybox one, the ping_do() command is broken. This comes by the fact that for coreutils ping, the ping IP needs to be the very last elements. To handle this, reorder the ping args and make $dip last element. The use of coreutils ping might b