Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-06 Thread Joe Perches
On Sun, 2020-09-06 at 07:47 +0530, Souptick Joarder wrote: > While running ./scripts/get_maintainer.pl, I observed one issue. Everytime I > run > the script, list is getting changed. Is it an expected behaviour ? Yes. https://lkml.org/lkml/2017/7/13/789

Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-05 Thread Souptick Joarder
On Sat, Sep 5, 2020 at 6:51 AM John Hubbard wrote: > > On 9/4/20 6:16 PM, Souptick Joarder wrote: > > Hi Andrew, > > > > On Wed, Sep 2, 2020 at 3:00 AM John Hubbard wrote: > >> > >> On 9/1/20 2:21 PM, Souptick Joarder wrote: > >>> First, when memory allocation for sg_list_unaligned failed, there

Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-04 Thread John Hubbard
On 9/4/20 6:16 PM, Souptick Joarder wrote: Hi Andrew, On Wed, Sep 2, 2020 at 3:00 AM John Hubbard wrote: On 9/1/20 2:21 PM, Souptick Joarder wrote: First, when memory allocation for sg_list_unaligned failed, there is a bug of calling put_pages() as we haven't pinned any pages. Second, if ge

Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-04 Thread Souptick Joarder
Hi Andrew, On Wed, Sep 2, 2020 at 3:00 AM John Hubbard wrote: > > On 9/1/20 2:21 PM, Souptick Joarder wrote: > > First, when memory allocation for sg_list_unaligned failed, there > > is a bug of calling put_pages() as we haven't pinned any pages. > > > > Second, if get_user_pages_fast() failed we

Re: [linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-01 Thread John Hubbard
On 9/1/20 2:21 PM, Souptick Joarder wrote: First, when memory allocation for sg_list_unaligned failed, there is a bug of calling put_pages() as we haven't pinned any pages. Second, if get_user_pages_fast() failed we should unpin num_pinned pages. This will address both. As part of these change

[linux-next PATCH v4] drivers/virt/fsl_hypervisor: Fix error handling path

2020-09-01 Thread Souptick Joarder
First, when memory allocation for sg_list_unaligned failed, there is a bug of calling put_pages() as we haven't pinned any pages. Second, if get_user_pages_fast() failed we should unpin num_pinned pages. This will address both. As part of these changes, minor update in documentation. Fixes: 6db