Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-17 Thread Avi Kivity
Luca Tettamanti wrote: Actually we haven't; just before the memcpy(), we can put a memcmp() to guard the kvm_mmu_pte_write(), which is the really expensive operation, especially with guest smp. Yup, but it seemed wasteful to map (at least when highmem is in use) a page just to check for so

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-17 Thread Luca Tettamanti
Il Sat, Jun 16, 2007 at 10:43:23AM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > > Il Fri, Jun 15, 2007 at 12:06:50PM +0300, Avi Kivity ha scritto: > > > >>> After a bit of thinking: it's correct but removes an optimization; > >>> furthermore it may miss other instructions that writ

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-16 Thread Avi Kivity
Luca Tettamanti wrote: > Il Fri, Jun 15, 2007 at 12:06:50PM +0300, Avi Kivity ha scritto: > >>> After a bit of thinking: it's correct but removes an optimization; >>> furthermore it may miss other instructions that write to memory mapped >>> areas. >>> A more proper fix should be "force the wri

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-15 Thread Luca Tettamanti
Il Fri, Jun 15, 2007 at 12:06:50PM +0300, Avi Kivity ha scritto: > > After a bit of thinking: it's correct but removes an optimization; > > furthermore it may miss other instructions that write to memory mapped > > areas. > > A more proper fix should be "force the writeback if dst.ptr is in some >

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-15 Thread Avi Kivity
Luca wrote: >> >> Got it! >> The emulator skips the writeback if the old value is unchanged, so the >> apic doesn't see the write. >> >> Forcing the writeback: >> >> - if ((d & Mov) || (dst.orig_val != dst.val)) { >> - if ((d & Mov) || (dst.orig_val != dst.val) || isxchg) { >> >> seems to

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-14 Thread Luca
On 6/15/07, Luca Tettamanti <[EMAIL PROTECTED]> wrote: Il Fri, Jun 15, 2007 at 12:53:24AM +0200, Luca Tettamanti ha scritto: > Il Thu, Jun 14, 2007 at 11:26:29AM +0300, Avi Kivity ha scritto: > > Luca Tettamanti wrote: > > >With GOOD_APIC apic_read_around is a nop, while apic_write_around is a >

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-14 Thread Luca Tettamanti
Il Fri, Jun 15, 2007 at 12:53:24AM +0200, Luca Tettamanti ha scritto: > Il Thu, Jun 14, 2007 at 11:26:29AM +0300, Avi Kivity ha scritto: > > Luca Tettamanti wrote: > > >With GOOD_APIC apic_read_around is a nop, while apic_write_around is a > > >normal write. With !GOOD_APIC apic_write_around writ

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-14 Thread Luca Tettamanti
Il Thu, Jun 14, 2007 at 11:26:29AM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > >With GOOD_APIC apic_read_around is a nop, while apic_write_around is a > >normal write. With !GOOD_APIC apic_write_around writes to the APIC reg > >using xchg. With !GOOD_APIC and this patch: > > > >--- in

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-14 Thread Luca Tettamanti
Il Thu, Jun 14, 2007 at 11:26:29AM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > >With GOOD_APIC apic_read_around is a nop, while apic_write_around is a > >normal write. With !GOOD_APIC apic_write_around writes to the APIC reg > >using xchg. With !GOOD_APIC and this patch: > > > >--- in

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-14 Thread Avi Kivity
Luca Tettamanti wrote: With GOOD_APIC apic_read_around is a nop, while apic_write_around is a normal write. With !GOOD_APIC apic_write_around writes to the APIC reg using xchg. With !GOOD_APIC and this patch: --- include/asm-i386/apic.h~2007-04-26 05:08:32.0 +0200 +++ include/asm-i38

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-13 Thread Luca Tettamanti
Il Wed, Jun 13, 2007 at 11:59:25AM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > >Il Mon, Jun 11, 2007 at 10:44:45AM +0300, Avi Kivity ha scritto: > > > >>Luca wrote: > >> > I've managed to reproduce this on kvm-21 (it takes many boots for this > to happen, but it does ev

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-13 Thread Avi Kivity
Luca Tettamanti wrote: Il Mon, Jun 11, 2007 at 10:44:45AM +0300, Avi Kivity ha scritto: Luca wrote: I've managed to reproduce this on kvm-21 (it takes many boots for this to happen, but it does eventually). Hum, any clue on the cause? From what I've seen, it's the new

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-12 Thread Luca Tettamanti
Il Mon, Jun 11, 2007 at 10:44:45AM +0300, Avi Kivity ha scritto: > Luca wrote: > >> > >>I've managed to reproduce this on kvm-21 (it takes many boots for this > >>to happen, but it does eventually). > > > >Hum, any clue on the cause? > > From what I've seen, it's the new Linux clocksource code.

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-11 Thread Avi Kivity
Luca wrote: > On 6/11/07, Avi Kivity <[EMAIL PROTECTED]> wrote: >> Luca wrote: >> >> >> >> I've managed to reproduce this on kvm-21 (it takes many boots for >> this >> >> to happen, but it does eventually). >> > >> > Hum, any clue on the cause? >> >> From what I've seen, it's the new Linux clockso

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-11 Thread Luca
On 6/11/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Luca wrote: >> >> I've managed to reproduce this on kvm-21 (it takes many boots for this >> to happen, but it does eventually). > > Hum, any clue on the cause? From what I've seen, it's the new Linux clocksource code. Actually I tried forcing

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-11 Thread Avi Kivity
Luca wrote: I've managed to reproduce this on kvm-21 (it takes many boots for this to happen, but it does eventually). Hum, any clue on the cause? From what I've seen, it's the new Linux clocksource code. Should I test older versions? They're unlikely to be better. Instead, it would be

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-10 Thread Luca
On 6/10/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Luca wrote: > On 6/5/07, Avi Kivity <[EMAIL PROTECTED]> wrote: >> Luca Tettamanti wrote: >> > Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: >> > >> >>> While doing repeated tests with the installer I ran into another >> >>> (unr

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-10 Thread Avi Kivity
Luca wrote: On 6/5/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Luca Tettamanti wrote: > Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: > >>> While doing repeated tests with the installer I ran into another >>> (unrelated) problem. Sometimes the guest kernel hangs at boot at: >>>

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-07 Thread Luca
On 6/5/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Luca Tettamanti wrote: > Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: > >>> While doing repeated tests with the installer I ran into another >>> (unrelated) problem. Sometimes the guest kernel hangs at boot at: >>> >>> NET: Regi

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-05 Thread Avi Kivity
Luca Tettamanti wrote: Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: While doing repeated tests with the installer I ran into another (unrelated) problem. Sometimes the guest kernel hangs at boot at: NET: Registered protocol family 2 with any kind of networking options (e

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Luca Tettamanti
Il Mon, Jun 04, 2007 at 11:51:10PM +0300, Avi Kivity ha scritto: > > While doing repeated tests with the installer I ran into another > > (unrelated) problem. Sometimes the guest kernel hangs at boot at: > > > > NET: Registered protocol family 2 > > > > with any kind of networking options (except

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Avi Kivity
Luca Tettamanti wrote: > It turned out that it was somewhat reproducible with fedora installer. > With your patch it doesn't oops anymore. > > Ok, good. > While doing repeated tests with the installer I ran into another > (unrelated) problem. Sometimes the guest kernel hangs at boot at: > > NE

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Luca Tettamanti
Hi, Il Mon, Jun 04, 2007 at 12:35:37PM +0300, Avi Kivity ha scritto: > Luca Tettamanti wrote: > >Hello, > >my kernel just exploded :) > > > >The host is running 2.6-git-current, with KVM modules from KVM-27 > >package. kernel is 32bit, SMP, with PREEMPT enabled, no HIGHMEM (but I'm > >using CONFI

Re: [kvm-devel] [BUG] Oops with KVM-27

2007-06-04 Thread Avi Kivity
Luca Tettamanti wrote: Hello, my kernel just exploded :) The host is running 2.6-git-current, with KVM modules from KVM-27 package. kernel is 32bit, SMP, with PREEMPT enabled, no HIGHMEM (but I'm using CONFIG_VMSPLIT_3G_OPT=y). The CPU is a Core2 (hence I'm using kvm-intel). Guest was a Fedora7