Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread PaX Team
> On Mon, Nov 9, 2015 at 1:55 PM, Julia Lawall wrote: > >> > What happens if some structures cannot be made const because there is a > >> > reassignment somewhere? Is there any feedback about the problem? the constify plugin basically simulates what a source level 'const' would do (sets a specif

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Kees Cook
On Mon, Nov 9, 2015 at 1:55 PM, Julia Lawall wrote: > On Mon, 9 Nov 2015, Kees Cook wrote: > >> On Mon, Nov 9, 2015 at 9:48 AM, Julia Lawall wrote: >> > On Mon, 9 Nov 2015, Emese Revfy wrote: >> > >> >> On Mon, 9 Nov 2015 14:50:47 + (GMT) >> >> Julia Lawall wrote: >> >> > > Actually, it look

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Julia Lawall
On Mon, 9 Nov 2015, Kees Cook wrote: > On Mon, Nov 9, 2015 at 9:48 AM, Julia Lawall wrote: > > On Mon, 9 Nov 2015, Emese Revfy wrote: > > > >> On Mon, 9 Nov 2015 14:50:47 + (GMT) > >> Julia Lawall wrote: > >> > > Actually, it looks like Emese Revfy is going to merge the GCC plugin > >> > > c

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Kees Cook
On Mon, Nov 9, 2015 at 9:48 AM, Julia Lawall wrote: > On Mon, 9 Nov 2015, Emese Revfy wrote: > >> On Mon, 9 Nov 2015 14:50:47 + (GMT) >> Julia Lawall wrote: >> > > Actually, it looks like Emese Revfy is going to merge the GCC plugin >> > > constify stuff sooner rather than later so maybe addi

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Joe Perches
On Mon, 2015-11-09 at 18:12 +, Julia Lawall wrote: > > On Mon, 9 Nov 2015, Dan Carpenter wrote: > > > Yeah, that's tricky and I don't have an answer but marking things as > > const is a worth while in itself because it makes static some analysis > > easier. > > I'm not clear on how to procee

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Julia Lawall
On Mon, 9 Nov 2015, Dan Carpenter wrote: > Yeah, that's tricky and I don't have an answer but marking things as > const is a worth while in itself because it makes static some analysis > easier. I'm not clear on how to proceed here... julia -- To unsubscribe from this list: send the line "unsu

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Julia Lawall
On Mon, 9 Nov 2015, Emese Revfy wrote: > On Mon, 9 Nov 2015 14:50:47 + (GMT) > Julia Lawall wrote: > > > Actually, it looks like Emese Revfy is going to merge the GCC plugin > > > constify stuff sooner rather than later so maybe adding all these consts > > > isn't going to be needed. > > > >

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Emese Revfy
On Mon, 9 Nov 2015 14:50:47 + (GMT) Julia Lawall wrote: > > Actually, it looks like Emese Revfy is going to merge the GCC plugin > > constify stuff sooner rather than later so maybe adding all these consts > > isn't going to be needed. > > Is there any advantage of const over the plugin? The

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Dan Carpenter
On Mon, Nov 09, 2015 at 02:50:47PM +, Julia Lawall wrote: > > > On Mon, 9 Nov 2015, Dan Carpenter wrote: > > > Actually, it looks like Emese Revfy is going to merge the GCC plugin > > constify stuff sooner rather than later so maybe adding all these consts > > isn't going to be needed. > >

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Julia Lawall
On Mon, 9 Nov 2015, Dan Carpenter wrote: > Actually, it looks like Emese Revfy is going to merge the GCC plugin > constify stuff sooner rather than later so maybe adding all these consts > isn't going to be needed. Is there any advantage of const over the plugin? The consts are easy to add. D

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Dan Carpenter
Actually, it looks like Emese Revfy is going to merge the GCC plugin constify stuff sooner rather than later so maybe adding all these consts isn't going to be needed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures

2015-11-09 Thread Dan Carpenter
Yeah, that's tricky and I don't have an answer but marking things as const is a worth while in itself because it makes static some analysis easier. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o