Re: [f2fs-dev] [PATCH] f2fs: use bio count instead of F2FS_WRITEBACK page count

2016-05-22 Thread Chao Yu
On 2016/5/18 9:31, Jaegeuk Kim wrote: > On Wed, May 18, 2016 at 09:17:00AM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/5/18 8:44, Jaegeuk Kim wrote: >>> This can reduce page counting overhead. >> >> We change to increase one reference for one bio, but block layer can split or >> merge bios b

Re: [f2fs-dev] [PATCH] f2fs: use bio count instead of F2FS_WRITEBACK page count

2016-05-17 Thread Jaegeuk Kim
On Wed, May 18, 2016 at 09:17:00AM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/5/18 8:44, Jaegeuk Kim wrote: > > This can reduce page counting overhead. > > We change to increase one reference for one bio, but block layer can split or > merge bios by itself, and write_end will be called per b

Re: [f2fs-dev] [PATCH] f2fs: use bio count instead of F2FS_WRITEBACK page count

2016-05-17 Thread Chao Yu
Hi Jaegeuk, On 2016/5/18 8:44, Jaegeuk Kim wrote: > This can reduce page counting overhead. We change to increase one reference for one bio, but block layer can split or merge bios by itself, and write_end will be called per bio, so the reference may be maintained incorrectly? Thanks, > > Sign