Re: [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Paul Menage
On 1/15/07, Balbir Singh <[EMAIL PROTECTED]> wrote: In sched.c, account_user_time() can be called with the task p set to rq->idle. Since idle tasks do not belong to any container, this was causing a panic in task_ca() in cpu_acct.c. How come that didn't cause a problem on x86_64? If this is an

[PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Balbir Singh
Balbir Singh wrote: > Paul Menage wrote: >> On 1/10/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >>> I have run into a problem running this patch on a powerpc box. Basically, >>> the machine panics as soon as I mount the container filesystem with >> This is a multi-processor system? >> > Hi, Paul, >

[PATCH 0/1] Add mount/umount callbacks to containers (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Balbir Singh
Paul Menage wrote: > On 1/10/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> I have run into a problem running this patch on a powerpc box. Basically, >> the machine panics as soon as I mount the container filesystem with > > This is a multi-processor system? > > My guess is that it's a race in th

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Paul Menage
On 1/12/07, Balbir Singh <[EMAIL PROTECTED]> wrote: I understand that the features are exported to userspace. But from the userspace POV only the mount options change - right? The mount options, plus the fact that you can mount different instances of containerfs with different resource contro

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Balbir Singh
Paul Menage wrote: > On 1/11/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> I tried something similar, I added an activated field, which is set >> to true when the ->create() callback is invoked. That did not help >> either, the machine still panic'ed. > > I think that marking it active when creat

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-12 Thread Paul Menage
On 1/11/07, Balbir Singh <[EMAIL PROTECTED]> wrote: I tried something similar, I added an activated field, which is set to true when the ->create() callback is invoked. That did not help either, the machine still panic'ed. I think that marking it active when create() is called may be too soon.

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-11 Thread Balbir Singh
Paul Menage wrote: > On 1/10/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> I have run into a problem running this patch on a powerpc box. Basically, >> the machine panics as soon as I mount the container filesystem with > > This is a multi-processor system? Yes, it has 4 cpus > > My guess is t

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-11 Thread Paul Menage
On 1/10/07, Balbir Singh <[EMAIL PROTECTED]> wrote: I have run into a problem running this patch on a powerpc box. Basically, the machine panics as soon as I mount the container filesystem with This is a multi-processor system? My guess is that it's a race in the subsystem API that I've been

Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem

2007-01-10 Thread Balbir Singh
Paul Menage wrote: > This demonstrates how to use the generic container subsystem for a > simple resource tracker that counts the total CPU time used by all > processes in a container, during the time that they're members of the > container. > > Signed-off-by: Paul Menage <[EMAIL PROTECTED]> > H