Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Nick Piggin
On Friday 01 February 2008 21:31, Jens Axboe wrote: > On Fri, Feb 01 2008, Jens Axboe wrote: > > I think the right solution is to remove swap_io_context() and fix the io > > context referencing in as-iosched.c instead. > > IOW, the below. I don't know why Nick originally wanted to swap io > contex

Re: Fwd: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Nikanth Karthikesan
> > am i right that lockdep complained about real lockup potential here? > > (i.e. it caught a real bug) So there's no need to change anything on the > > lockdep side, right? > > Right, no bug in lockdep, the locking code and swap_io_context() are > just screwed up. > I doubt a bug in lockdep. H

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Ingo Molnar wrote: > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Fri, Feb 01 2008, Ingo Molnar wrote: > > > > > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > Are you sure this triggered with the as fixup in place? It looks like > > > > the same bug. > > >

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Ingo Molnar
* Jens Axboe <[EMAIL PROTECTED]> wrote: > On Fri, Feb 01 2008, Ingo Molnar wrote: > > > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > Are you sure this triggered with the as fixup in place? It looks like > > > the same bug. > > > > most definitely a separate bug. > > yeah, I didn't rea

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Nikanth Karthikesan
On Fri, 2008-02-01 at 11:12 +0100, Jens Axboe wrote: > On Fri, Feb 01 2008, Nikanth Karthikesan wrote: > > On Thu, 2008-01-31 at 23:14 +0100, Ingo Molnar wrote: > > > > > > Jens, > > > > > > AS still has some locking issues - see the lockdep warning below that > > > the x86 test-rig just trigge

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Ingo Molnar wrote: > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > Are you sure this triggered with the as fixup in place? It looks like > > the same bug. > > most definitely a separate bug. yeah, I didn't read it carefully enough. Nikanth found the reason. -- Jens Axb

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Ingo Molnar
* Jens Axboe <[EMAIL PROTECTED]> wrote: > Are you sure this triggered with the as fixup in place? It looks like > the same bug. most definitely a separate bug. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Jens Axboe wrote: > On Fri, Feb 01 2008, Nikanth Karthikesan wrote: > > On Thu, 2008-01-31 at 23:14 +0100, Ingo Molnar wrote: > > > > > > Jens, > > > > > > AS still has some locking issues - see the lockdep warning below that > > > the x86 test-rig just triggered. Config att

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Nikanth Karthikesan wrote: > On Thu, 2008-01-31 at 23:14 +0100, Ingo Molnar wrote: > > > > Jens, > > > > AS still has some locking issues - see the lockdep warning below that > > the x86 test-rig just triggered. Config attached. Never saw this one > > before. Can send more

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Nikanth Karthikesan
On Thu, 2008-01-31 at 23:14 +0100, Ingo Molnar wrote: > > Jens, > > AS still has some locking issues - see the lockdep warning below that > the x86 test-rig just triggered. Config attached. Never saw this one > before. Can send more info if needed. > The io_contexts are swapped. And while swa

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Thu, Jan 31 2008, Ingo Molnar wrote: > > > Jens, > > AS still has some locking issues - see the lockdep warning below that > the x86 test-rig just triggered. Config attached. Never saw this one > before. Can send more info if needed. > > Ingo > > --> > udev: renamed network

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-01-31 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > Jens, > > AS still has some locking issues - see the lockdep warning below that > the x86 test-rig just triggered. Config attached. Never saw this one > before. Can send more info if needed. btw., it didnt reproduce after a reboot, so it seems like a

[bug] as_merged_requests(): possible recursive locking detected

2008-01-31 Thread Ingo Molnar
Jens, AS still has some locking issues - see the lockdep warning below that the x86 test-rig just triggered. Config attached. Never saw this one before. Can send more info if needed. Ingo --> udev: renamed network interface eth0_rename to eth1 ===