Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-20 Thread Heiko Carstens
On Sat, Oct 11, 2014 at 11:25:14PM +0100, Thomas Graf wrote: > On 10/11/14 at 12:32pm, Eric Dumazet wrote: > > On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > > > Hi all, > > > > > > it just came to my attention that commit e341694e3eb5 > > > "netlink: Convert netlink_lookup() to use RC

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread David Miller
From: Thomas Graf Date: Sat, 11 Oct 2014 23:25:14 +0100 > I think the issue here is obvious and a fix is on the way to move > the insertion and removal to a worker to no longer require the > synchronize_rcu(). > > What bothers me is that the synchronize_rcu() should only occur > on expand/shrink

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Thomas Graf
On 10/11/14 at 12:32pm, Eric Dumazet wrote: > On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > > Hi all, > > > > it just came to my attention that commit e341694e3eb5 > > "netlink: Convert netlink_lookup() to use RCU protected hash table" > > causes network latencies for me on s390. > >

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Eric Dumazet
On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > Hi all, > > it just came to my attention that commit e341694e3eb5 > "netlink: Convert netlink_lookup() to use RCU protected hash table" > causes network latencies for me on s390. > > The testcase is quite simple and 100% reproducible on s

[bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Heiko Carstens
Hi all, it just came to my attention that commit e341694e3eb5 "netlink: Convert netlink_lookup() to use RCU protected hash table" causes network latencies for me on s390. The testcase is quite simple and 100% reproducible on s390: Simply login via ssh to a remote system which has the above menti