Re: [alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure

2016-06-09 Thread Mark Brown
On Wed, Jun 08, 2016 at 10:06:12AM +0800, Garlic Tseng wrote: > On Tue, 2016-06-07 at 16:54 +0100, Mark Brown wrote: > > Do you need to export the individual ops rather than just the ops > > structure? > Yes, in 2701 driver we modify some ops. OK. signature.asc Description: PGP signature

Re: [alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure

2016-06-07 Thread Garlic Tseng
Hi Mark, thank for comment. On Tue, 2016-06-07 at 16:54 +0100, Mark Brown wrote: > On Fri, Jun 03, 2016 at 12:56:17PM +0800, Garlic Tseng wrote: > > > + /*enable agent*/ > > Lots of comments with missing spaces in them, there's quite a few > examples of that in here. I'll check all the code a

Re: [alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure

2016-06-07 Thread Mark Brown
On Fri, Jun 03, 2016 at 12:56:17PM +0800, Garlic Tseng wrote: > + /*enable agent*/ Lots of comments with missing spaces in them, there's quite a few examples of that in here. > +EXPORT_SYMBOL(mtk_afe_fe_startup); All the ASoC and regmap APIs are _GPL(), you really shouldn't export new inter

[alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure

2016-06-02 Thread Garlic Tseng
implement mediatek basic structure, include common private data, afe fe dai operator and afe platform driver. Signed-off-by: Garlic Tseng --- sound/soc/mediatek/common/mtk-afe-fe-dai.c | 387 + sound/soc/mediatek/common/mtk-afe-fe-dai.h | 47 +++ .../soc/medi