Re: [alsa-devel] [PATCH v2] ASoC: codecs: Add DA9055 codec driver

2012-09-20 Thread Mark Brown
On Thu, Sep 20, 2012 at 05:28:55PM +0530, Ashish Chavan wrote: > > > + /* To select if MIC Bias powers MIC 1 or MIC 2 */ > > > + SOC_ENUM("Mic Bias Select", da9055_mic_bias_select), > > This would normally be something controlled by the board... what > > exactly is this doing? How does the MICB

Re: [alsa-devel] [PATCH v2] ASoC: codecs: Add DA9055 codec driver

2012-09-20 Thread Ashish Chavan
> > + /* DAC Routing control */ > > + SOC_ENUM("DAC Left Select", da9055_dac_l_select), > > + SOC_ENUM("DAC Right Select", da9055_dac_r_select), > > DAPM. This even says its a routing control... Yes, let me see if I can make it DAPM based. > > > + /* To select if MIC Bias powers MIC 1

Re: [alsa-devel] [PATCH v2] ASoC: codecs: Add DA9055 codec driver

2012-09-18 Thread Mark Brown
On Fri, Sep 14, 2012 at 04:57:37PM +0530, Ashish Chavan wrote: This looks like a good improvement, a few issues remain though: > + /* DAC Routing control */ > + SOC_ENUM("DAC Left Select", da9055_dac_l_select), > + SOC_ENUM("DAC Right Select", da9055_dac_r_select), DAPM. This even s

[alsa-devel] [PATCH v2] ASoC: codecs: Add DA9055 codec driver

2012-09-14 Thread Ashish Chavan
This patch adds support for Dialog semiconductor's DA9055 audio codec. This has been tested on DA9055 EVB with Samsung SMDK6410 board. Signed-off-by: Ashish Chavan Signed-off-by: David Dajun Chen --- Changes since v1: - Made extensive use of DAPM throughout the driver - Removed LDO, DMIC and o