Re: [alsa-devel] [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support

2017-11-13 Thread Pierre-Louis Bossart
On 11/10/17 8:48 PM, Ruslan Bilovol wrote: On Wed, Nov 8, 2017 at 9:38 PM, Pierre-Louis Bossart wrote: Nice work, thanks! I double-checked all the descriptors and values and didn't find anything problematic, the main comment I have is that the clock source/selection could probably be refactored

Re: [alsa-devel] [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support

2017-11-10 Thread Ruslan Bilovol
On Wed, Nov 8, 2017 at 9:38 PM, Pierre-Louis Bossart wrote: > Nice work, thanks! I double-checked all the descriptors and values and > didn't find anything problematic, the main comment I have is that the clock > source/selection could probably be refactored since the differences are > really mino

Re: [alsa-devel] [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support

2017-11-08 Thread Pierre-Louis Bossart
Nice work, thanks! I double-checked all the descriptors and values and didn't find anything problematic, the main comment I have is that the clock source/selection could probably be refactored since the differences are really minor with UAC2, and there is work to do to select the right Audio In