Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits

2016-12-01 Thread Brian Austin
On Thu, 1 Dec 2016, Charles Keepax wrote: > On Tue, Nov 29, 2016 at 06:10:49PM +0100, Florian Vaussard wrote: > > Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) > > and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform > > (mask & 1), which results in 0 if

Re: [alsa-devel] [PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits

2016-12-01 Thread Charles Keepax
On Tue, Nov 29, 2016 at 06:10:49PM +0100, Florian Vaussard wrote: > Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) > and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform > (mask & 1), which results in 0 if LSB of mask is 0. Thus the call > regmap_update_bit