Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-30 Thread Mark Brown
On Tue, Dec 30, 2014 at 10:29:18AM +0800, Zidan Wang wrote: > I want put mclk enable to set_bias_level. Do you thinks it make sense? That should work as well, yes. signature.asc Description: Digital signature

Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-29 Thread Zidan Wang
On Mon, Dec 29, 2014 at 04:05:14PM +, Mark Brown wrote: > On Mon, Dec 29, 2014 at 10:59:08AM +, Zidan Wang wrote: > > Hi Mark, > > Don't top post and please fix your mailer to word wrap within paragraphs > and avoid corrupting the mail it's quoting. > > > You are right. When PM is disable

Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-29 Thread Mark Brown
On Mon, Dec 29, 2014 at 10:59:08AM +, Zidan Wang wrote: > Hi Mark, Don't top post and please fix your mailer to word wrap within paragraphs and avoid corrupting the mail it's quoting. > You are right. When PM is disabled, the codec will not work. But there are > also some codecs enable mclk

RE: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-29 Thread Zidan Wang
ckee...@opensource.wolfsonmicro.com; Xiubo Li-B47053; patc...@opensource.wolfsonmicro.com; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org Subject: Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK On Tue, Dec 09, 2014 at 01:45:16PM +0800, Zidan Wang

Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-22 Thread Mark Brown
On Tue, Dec 09, 2014 at 01:45:16PM +0800, Zidan Wang wrote: > @@ -1002,6 +1005,13 @@ static int wm8960_i2c_probe(struct i2c_client *i2c, > if (wm8960 == NULL) > return -ENOMEM; > > + wm8960->mclk = devm_clk_get(&i2c->dev, "codec_mclk"); > + > + if (IS_ERR(wm8960->mclk

Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-11 Thread Charles Keepax
On Tue, Dec 09, 2014 at 01:45:16PM +0800, Zidan Wang wrote: > When we want to use wm8960 codec, we should enable its MCLK in machine > driver. It's reasonable for wm8960 codec driver to manage its own MCLK to > save power. > > Enable runtime power management, and auto enable/disable MCLK in pm_run

[alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK

2014-12-08 Thread Zidan Wang
When we want to use wm8960 codec, we should enable its MCLK in machine driver. It's reasonable for wm8960 codec driver to manage its own MCLK to save power. Enable runtime power management, and auto enable/disable MCLK in pm_runtime resume and suspend. When wm8960 codec is being used, it will trig