Re: [Xen-devel] [PATCH V3 6/6]: PVH:privcmd changes.

2012-10-18 Thread Mukesh Rathor
On Thu, 18 Oct 2012 11:35:53 +0100 Ian Campbell wrote: > > > @@ -439,6 +490,19 @@ static long privcmd_ioctl(struct file *file, > > return ret; > > } > > > > +static void privcmd_close(struct vm_area_struct *vma) > > +{ > > + struct page **pages = vma ? vma->vm_private_data : NULL; > >

Re: [Xen-devel] [PATCH V3 6/6]: PVH:privcmd changes.

2012-10-18 Thread Ian Campbell
> @@ -439,6 +490,19 @@ static long privcmd_ioctl(struct file *file, > return ret; > } > > +static void privcmd_close(struct vm_area_struct *vma) > +{ > + struct page **pages = vma ? vma->vm_private_data : NULL; Can VMA really be NULL?... > + int numpgs = (vma->vm_end - vma->vm_s