Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 06:00:51PM +0100, Roger Pau Monné wrote: > On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > > On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > > wrote: > >>> 'op' sounds good. With a comment saying it

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Roger Pau Monné
On 05/03/13 15:16, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > wrote: >>> 'op' sounds good. With a comment saying it can do all of the >>> BLKIF_OPS_.. >>> except the BLKIF_OP_INDIRECT one. T

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Konrad Rzeszutek Wilk
On Tue, Mar 05, 2013 at 08:11:19AM +, Jan Beulich wrote: > >>> On 04.03.13 at 21:44, Konrad Rzeszutek Wilk > >>> wrote: > > 'op' sounds good. With a comment saying it can do all of the > > BLKIF_OPS_.. > > except the BLKIF_OP_INDIRECT one. Thought one could in theory chain > > it that way f

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-05 Thread Jan Beulich
>>> On 04.03.13 at 21:44, Konrad Rzeszutek Wilk wrote: > 'op' sounds good. With a comment saying it can do all of the > BLKIF_OPS_.. > except the BLKIF_OP_INDIRECT one. Thought one could in theory chain > it that way for fun. In fact I'd like to exclude chaining as well as BLKIF_OP_DISCARD here

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-03-04 Thread Konrad Rzeszutek Wilk
On Thu, Feb 28, 2013 at 01:28:48PM +, Jan Beulich wrote: > >>> On 28.02.13 at 13:00, Roger Pau Monné wrote: > > On 28/02/13 12:19, Jan Beulich wrote: > > On 28.02.13 at 11:28, Roger Pau Monne wrote: > >>> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; > >>> */ > >>> #define BLKIF

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
>>> On 28.02.13 at 13:00, Roger Pau Monné wrote: > On 28/02/13 12:19, Jan Beulich wrote: > On 28.02.13 at 11:28, Roger Pau Monne wrote: >>> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; >>> */ >>> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 >>> >>> +#define BLKIF_MAX_INDIRECT_GREFS_

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Roger Pau Monné
On 28/02/13 12:19, Jan Beulich wrote: On 28.02.13 at 11:28, Roger Pau Monne wrote: >> @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; >> */ >> #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 >> >> +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 >> + >> +struct blkif_request_segment_align

Re: [Xen-devel] [PATCH RFC 12/12] xen-block: implement indirect descriptors

2013-02-28 Thread Jan Beulich
>>> On 28.02.13 at 11:28, Roger Pau Monne wrote: > @@ -109,6 +111,16 @@ typedef uint64_t blkif_sector_t; > */ > #define BLKIF_MAX_SEGMENTS_PER_REQUEST 11 > > +#define BLKIF_MAX_INDIRECT_GREFS_PER_REQUEST 8 > + > +struct blkif_request_segment_aligned { > + grant_ref_t gref;/* refer