Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-30 Thread Chen Gang
On 9/30/14 15:50, Chen Gang wrote: > On 9/30/14 14:59, Juergen Gross wrote: >> On 09/30/2014 08:32 AM, Chen Gang wrote: >>> On 9/29/14 21:57, David Vrabel wrote: On 29/09/14 10:59, Chen Gang wrote: > > > If no any additional reply within 2 days, I shall send patch v2 for it: >

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-30 Thread Chen Gang
On 9/30/14 14:59, Juergen Gross wrote: > On 09/30/2014 08:32 AM, Chen Gang wrote: >> On 9/29/14 21:57, David Vrabel wrote: >>> On 29/09/14 10:59, Chen Gang wrote: If no any additional reply within 2 days, I shall send patch v2 for it: "use dev_warn() instead of xenbus_de

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-30 Thread Juergen Gross
On 09/30/2014 08:32 AM, Chen Gang wrote: On 9/29/14 21:57, David Vrabel wrote: On 29/09/14 10:59, Chen Gang wrote: If no any additional reply within 2 days, I shall send patch v2 for it: "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block" I think this driver is f

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread Chen Gang
On 9/29/14 21:57, David Vrabel wrote: > On 29/09/14 10:59, Chen Gang wrote: >> >> >> If no any additional reply within 2 days, I shall send patch v2 for it: >> >> "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block" > > I think this driver is fine as-is and does not need a

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread David Vrabel
On 29/09/14 10:59, Chen Gang wrote: > > > If no any additional reply within 2 days, I shall send patch v2 for it: > > "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block" I think this driver is fine as-is and does not need any changes. David -- To unsubscribe from this

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread Chen Gang
On 9/29/14 17:34, Juergen Gross wrote: > On 09/29/2014 11:31 AM, Chen Gang wrote: >> On 9/29/14 16:41, Jan Beulich wrote: >> On 29.09.14 at 06:32, wrote: On 09/26/2014 06:38 PM, Chen Gang wrote: > When failure occurs, after xenbus_dev_error(), need go to fail to let > upper caller

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread Juergen Gross
On 09/29/2014 11:31 AM, Chen Gang wrote: On 9/29/14 16:41, Jan Beulich wrote: On 29.09.14 at 06:32, wrote: On 09/26/2014 06:38 PM, Chen Gang wrote: When failure occurs, after xenbus_dev_error(), need go to fail to let upper caller know about it. Signed-off-by: Chen Gang --- drivers/xen/x

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread Chen Gang
On 9/29/14 16:41, Jan Beulich wrote: On 29.09.14 at 06:32, wrote: >> On 09/26/2014 06:38 PM, Chen Gang wrote: >>> When failure occurs, after xenbus_dev_error(), need go to fail to let >>> upper caller know about it. >>> >>> Signed-off-by: Chen Gang >>> --- >>> drivers/xen/xen-scsiback.c |

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-29 Thread Jan Beulich
>>> On 29.09.14 at 06:32, wrote: > On 09/26/2014 06:38 PM, Chen Gang wrote: >> When failure occurs, after xenbus_dev_error(), need go to fail to let >> upper caller know about it. >> >> Signed-off-by: Chen Gang >> --- >> drivers/xen/xen-scsiback.c | 4 +++- >> 1 file changed, 3 insertions(+),

Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()

2014-09-28 Thread Juergen Gross
On 09/26/2014 06:38 PM, Chen Gang wrote: When failure occurs, after xenbus_dev_error(), need go to fail to let upper caller know about it. Signed-off-by: Chen Gang --- drivers/xen/xen-scsiback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xen-scsiback.c