Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Boris Ostrovsky
On 11/17/2015 02:37 PM, Boris Ostrovsky wrote: On 11/17/2015 02:16 PM, Andy Lutomirski wrote: Looks good to me. Does Xen have any sysexit/sysret32 equivalent to return to 32-bit user mode? If so, it could be worth trying to wire it up by patching the jz instead of the test instruction. We ca

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Andy Lutomirski
On Tue, Nov 17, 2015 at 11:29 AM, Andrew Cooper wrote: > On 17/11/15 19:16, Andy Lutomirski wrote: >> On Tue, Nov 17, 2015 at 11:12 AM, Andrew Cooper >> wrote: >>> On 17/11/15 18:49, Andy Lutomirski wrote: On Nov 17, 2015 6:40 AM, "Boris Ostrovsky" wrote: > On 11/16/2015 04:55 PM,

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Boris Ostrovsky
On 11/17/2015 02:16 PM, Andy Lutomirski wrote: Looks good to me. Does Xen have any sysexit/sysret32 equivalent to return to 32-bit user mode? If so, it could be worth trying to wire it up by patching the jz instead of the test instruction. We can actually make patching a little bit more effic

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Andrew Cooper
On 17/11/15 19:16, Andy Lutomirski wrote: > On Tue, Nov 17, 2015 at 11:12 AM, Andrew Cooper > wrote: >> On 17/11/15 18:49, Andy Lutomirski wrote: >>> On Nov 17, 2015 6:40 AM, "Boris Ostrovsky" >>> wrote: On 11/16/2015 04:55 PM, H. Peter Anvin wrote: > On 11/16/15 12:22, Borislav Petkov

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Borislav Petkov
On Tue, Nov 17, 2015 at 11:16:11AM -0800, Andy Lutomirski wrote: > Works for me, too, although seeing "xen_pv_host" in the Linux cpu > features would be very strange indeed :) That feature would be, of course, *not* in /proc/cpuinfo. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails wh

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Andy Lutomirski
On Tue, Nov 17, 2015 at 11:12 AM, Andrew Cooper wrote: > On 17/11/15 18:49, Andy Lutomirski wrote: >> On Nov 17, 2015 6:40 AM, "Boris Ostrovsky" >> wrote: >>> On 11/16/2015 04:55 PM, H. Peter Anvin wrote: On 11/16/15 12:22, Borislav Petkov wrote: > Huh, so what's wrong with a jump:

Re: [Xen-devel] [PATCH] xen/x86: Adjust stack pointer in xen_sysexit

2015-11-17 Thread Andrew Cooper
On 17/11/15 18:49, Andy Lutomirski wrote: > On Nov 17, 2015 6:40 AM, "Boris Ostrovsky" wrote: >> On 11/16/2015 04:55 PM, H. Peter Anvin wrote: >>> On 11/16/15 12:22, Borislav Petkov wrote: Huh, so what's wrong with a jump: jmp 1f swapgs 1: >>>