Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-10-05 Thread Peter Zijlstra
On Fri, Oct 02, 2020 at 08:13:13PM +0200, Peter Zijlstra wrote: > > checks within the irq disabling to get rid of the using cpu pointers within > > preemptable code warnings > > Ah, I think I lost a s/__this_cpu_read/raw_cpu_read/ somewhere. The > thing is, if we're preemptible/migratable it will

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-10-02 Thread Peter Zijlstra
On Fri, Oct 02, 2020 at 01:56:44PM -0400, Steven Rostedt wrote: > On Wed, 30 Sep 2020 20:13:23 +0200 > Peter Zijlstra wrote: > > > Blergh, IIRC there's header hell that way. The sane fix is killing off > > that trace_*_rcuidle() disease. > > > > But I think this will also cure it. > > I guess y

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-10-02 Thread Steven Rostedt
On Wed, 30 Sep 2020 20:13:23 +0200 Peter Zijlstra wrote: > Blergh, IIRC there's header hell that way. The sane fix is killing off > that trace_*_rcuidle() disease. > > But I think this will also cure it. I guess you still don't build modules ;-). I had to add a EXPORT_SYMBOL(lockdep_recursion)

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-10-02 Thread Peter Zijlstra
On Wed, Sep 30, 2020 at 03:52:22PM -0400, Steven Rostedt wrote: > On Wed, 30 Sep 2020 21:22:42 +0200 > Peter Zijlstra wrote: > > > On Wed, Sep 30, 2020 at 03:10:26PM -0400, Steven Rostedt wrote: > > > On Wed, 30 Sep 2020 20:13:23 +0200 > > > Peter Zijlstra wrote: > > > > > > > diff --git a/i

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-30 Thread Steven Rostedt
On Wed, 30 Sep 2020 21:22:42 +0200 Peter Zijlstra wrote: > On Wed, Sep 30, 2020 at 03:10:26PM -0400, Steven Rostedt wrote: > > On Wed, 30 Sep 2020 20:13:23 +0200 > > Peter Zijlstra wrote: > > > > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > > > index 6a584b3e5c74..3

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-30 Thread Peter Zijlstra
On Wed, Sep 30, 2020 at 03:10:26PM -0400, Steven Rostedt wrote: > On Wed, 30 Sep 2020 20:13:23 +0200 > Peter Zijlstra wrote: > > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > > index 6a584b3e5c74..3e5bc1dd71c6 100644 > > > --- a/include/linux/lockdep.h > > > +++ b/include/

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-30 Thread Steven Rostedt
On Wed, 30 Sep 2020 20:13:23 +0200 Peter Zijlstra wrote: > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > index 6a584b3e5c74..3e5bc1dd71c6 100644 > > --- a/include/linux/lockdep.h > > +++ b/include/linux/lockdep.h > > @@ -550,7 +550,8 @@ do {

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-30 Thread Peter Zijlstra
On Thu, Sep 17, 2020 at 01:16:46PM -0400, Steven Rostedt wrote: > Hi Peter, > > I ran my tests on a series of patches on top of 5.9-rc4, and hit the > following splat: > > [ cut here ] > WARNING: CPU: 0 PID: 2557 at kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20 > RIP:

Re: [WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-25 Thread Steven Rostedt
Ping. -- Steve On Thu, 17 Sep 2020 13:18:16 -0400 Steven Rostedt wrote: > Hi Peter, > > I ran my tests on a series of patches on top of 5.9-rc4, and hit the > following splat: > > [ cut here ] > WARNING: CPU: 0 PID: 2557 at kernel/rcu/tree.c:1058 rcu_irq_enter+0x1

[WARNING] kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20

2020-09-17 Thread Steven Rostedt
Hi Peter, I ran my tests on a series of patches on top of 5.9-rc4, and hit the following splat: [ cut here ] WARNING: CPU: 0 PID: 2557 at kernel/rcu/tree.c:1058 rcu_irq_enter+0x15/0x20 Modules linked in: [..] CPU: 0 PID: 2557 Comm: ftracetest Tainted: GW