What this patch tried to do is to limit it to what userspace is
currently actually using. My mistake was to look only at BlueZ 5.x
userspace and not at BlueZ 4.x userspace. The fix to not break
existing userspace is essentially this:
>
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/c
Hi Linus,
>> accepting all flags regardless was an oversight on my part in the first
>> place. What this patch tried to do is to limit it to what userspace is
>> currently actually using. My mistake was to look only at BlueZ 5.x userspace
>> and not at BlueZ 4.x userspace.
>
> So what about an
On Fri, Apr 17, 2015 at 4:35 PM, Marcel Holtmann wrote:
>
> accepting all flags regardless was an oversight on my part in the first
> place. What this patch tried to do is to limit it to what userspace is
> currently actually using. My mistake was to look only at BlueZ 5.x userspace
> and not a
Hi Linus,
>> okay. I only looked at BlueZ 5.x and that might have been my mistake. Let me
>> check this and fix this properly.
>
> Why not just revert that commit. It looks like garbage. It has odd code like
>
> + u32 valid_flags = 0;
> + ci->flags = session->flags & valid_flags;
>
On Fri, Apr 17, 2015 at 1:02 PM, Marcel Holtmann wrote:
>
> okay. I only looked at BlueZ 5.x and that might have been my mistake. Let me
> check this and fix this properly.
Why not just revert that commit. It looks like garbage. It has odd code like
+ u32 valid_flags = 0;
+ ci->flag
Hi Joerg,
>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
>>> The BT mouse is "death" in v4.1.
>>> The BT mouse has been working in 4.0 and previous kernels, so this
>>> is a regression.
>>
>> Any chance of bisecting it?
>>
>>Linus
> I will t
Hi Joerg,
> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
>> The BT mouse is "death" in v4.1.
>> The BT mouse has been working in 4.0 and previous kernels, so this
>> is a regression.
>
> Any chance of bisecting it?
>
> Linus
I will try that.
2015-04-17 18:55 GMT+02:00 Jörg Otte :
> 2015-04-17 18:51 GMT+02:00 Marcel Holtmann :
>> Hi Joerg,
>>
> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
>> The BT mouse is "death" in v4.1.
>> The BT mouse has been working in 4.0 and previous kernels, so this
>> is a regression.
>>
2015-04-17 18:51 GMT+02:00 Marcel Holtmann :
> Hi Joerg,
>
On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
> The BT mouse is "death" in v4.1.
> The BT mouse has been working in 4.0 and previous kernels, so this
> is a regression.
Any chance of bisecting it?
Hi Joerg,
>>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
The BT mouse is "death" in v4.1.
The BT mouse has been working in 4.0 and previous kernels, so this
is a regression.
>>>
>>> Any chance of bisecting it?
>>>
>>> Linus
>> I will try that.
>>
>> Thanks, J
2015-04-17 16:51 GMT+02:00 Jörg Otte :
> 2015-04-17 15:44 GMT+02:00 Linus Torvalds :
>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
>>> The BT mouse is "death" in v4.1.
>>> The BT mouse has been working in 4.0 and previous kernels, so this
>>> is a regression.
>>
>> Any chance of bisecting i
2015-04-17 15:44 GMT+02:00 Linus Torvalds :
> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
>> The BT mouse is "death" in v4.1.
>> The BT mouse has been working in 4.0 and previous kernels, so this
>> is a regression.
>
> Any chance of bisecting it?
>
> Linus
I will try that.
Th
On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote:
> The BT mouse is "death" in v4.1.
> The BT mouse has been working in 4.0 and previous kernels, so this
> is a regression.
Any chance of bisecting it?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Hi Jörg,
On Fri, Apr 17, 2015 at 12:36 PM, Jörg Otte wrote:
> The BT mouse is "death" in v4.1.
> The BT mouse has been working in 4.0 and previous kernels, so this
> is a regression.
>
> BT adapter is an intel 8087:07da. The mouse is an MS Notebook Mouse 500.
>
> It just doesn't work without any
The BT mouse is "death" in v4.1.
The BT mouse has been working in 4.0 and previous kernels, so this
is a regression.
BT adapter is an intel 8087:07da. The mouse is an MS Notebook Mouse 500.
It just doesn't work without any errors displayed in dmesg.
Thanks, Jörg
--
To unsubscribe from this list:
15 matches
Mail list logo
