Re: [UBSAN] iwlmvm's iwl_mvm_enable_txq accesses IEEE80211_INVAL_HW_QUEUE

2017-06-23 Thread Johannes Berg
On Fri, 2017-06-23 at 09:48 +0200, Jiri Slaby wrote: > > mac80211_queue is 255 which is IEEE80211_INVAL_HW_QUEUE, so it should > not be worked with at all. Funny you should find this today :-) > The invalid queue is hopefully handled in ieee80211_check_queues > after > drv_add_interface in ieee8

[UBSAN] iwlmvm's iwl_mvm_enable_txq accesses IEEE80211_INVAL_HW_QUEUE

2017-06-23 Thread Jiri Slaby
Hi, we have got an UBSAN report from opensuse's user who booten UBSAN-enabled kernel by mistake: UBSAN: Undefined behaviour in drivers/net/wireless/intel/iwlwifi/mvm/utils.c:667:49 shift exponent 255 is too large for 64-bit type 'long unsigned int' CPU: 2 PID: 1590 Comm: wpa_supplicant Not tainted