Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-15 Thread Rafael J. Wysocki
On Wed, Nov 15, 2017 at 7:01 PM, Luis R. Rodriguez wrote: > On Wed, Nov 15, 2017 at 12:40:43AM +0100, Rafael J. Wysocki wrote: >> On Wednesday, November 15, 2017 12:07:30 AM CET Dave Chinner wrote: >> Can we stop here and be constructive going forward, please? > > Then let's stop this nonsense and

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-15 Thread Luis R. Rodriguez
On Wed, Nov 15, 2017 at 12:40:43AM +0100, Rafael J. Wysocki wrote: > On Wednesday, November 15, 2017 12:07:30 AM CET Dave Chinner wrote: > Can we stop here and be constructive going forward, please? Then let's stop this nonsense and get to work. > > > So what do you think should be done, specific

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-15 Thread Michal Hocko
On Wed 15-11-17 00:39:53, Yu Chen wrote: [...] > Before the filesystem freezing feature is merged into > upstream, wouldn't it be nice if we have some compromise > workaround for such kind of issues: how about treat the > always-sleeping tasks as frozen? They are safe to be > regarded as frozen bec

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Rafael J. Wysocki
On Wednesday, November 15, 2017 12:07:30 AM CET Dave Chinner wrote: > On Tue, Nov 14, 2017 at 11:01:57PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, November 14, 2017 10:25:38 PM CET Dave Chinner wrote: > > > On Tue, Nov 14, 2017 at 09:19:15PM +0100, Luis R. Rodriguez wrote: > > > > This is ano

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Dave Chinner
On Tue, Nov 14, 2017 at 11:01:57PM +0100, Rafael J. Wysocki wrote: > On Tuesday, November 14, 2017 10:25:38 PM CET Dave Chinner wrote: > > On Tue, Nov 14, 2017 at 09:19:15PM +0100, Luis R. Rodriguez wrote: > > > This is another way to say suspend has been busted on XFS for a very long > > > time,

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Rafael J. Wysocki
On Tuesday, November 14, 2017 10:25:38 PM CET Dave Chinner wrote: > On Tue, Nov 14, 2017 at 09:19:15PM +0100, Luis R. Rodriguez wrote: > > This is another way to say suspend has been busted on XFS for a very long > > time, > > but I would not blame XFS -- this is a kernel issue to get proper files

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Dave Chinner
On Tue, Nov 14, 2017 at 09:19:15PM +0100, Luis R. Rodriguez wrote: > This is another way to say suspend has been busted on XFS for a very long > time, > but I would not blame XFS -- this is a kernel issue to get proper filesystem > suspend working right, and the way we currently deal with kthreads

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Luis R. Rodriguez
On Mon, Nov 13, 2017 at 12:37:00PM -0800, Dan Williams wrote: > On Mon, Nov 13, 2017 at 12:14 PM, Luis R. Rodriguez wrote: > > On Mon, Nov 13, 2017 at 06:31:39PM +0800, Yu Chen wrote: > >> The xfs-buf/dm-1 should be freezed according to > >> commit 8018ec083c72 ("xfs: mark all internal workqueues

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-14 Thread Yu Chen
On Tue, Nov 14, 2017 at 03:02:32PM +1100, Dave Chinner wrote: > On Tue, Nov 14, 2017 at 11:39:59AM +0800, Yu Chen wrote: > > Hi Dave, > > On Tue, Nov 14, 2017 at 09:52:16AM +1100, Dave Chinner wrote: > > > On Mon, Nov 13, 2017 at 06:31:39PM +0800, Yu Chen wrote: > > > > Hi all, > > > > Currently we

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-13 Thread Dave Chinner
On Tue, Nov 14, 2017 at 11:39:59AM +0800, Yu Chen wrote: > Hi Dave, > On Tue, Nov 14, 2017 at 09:52:16AM +1100, Dave Chinner wrote: > > On Mon, Nov 13, 2017 at 06:31:39PM +0800, Yu Chen wrote: > > > Hi all, > > > Currently we are running hibernation stress test on a server > > > and unfortunately a

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-13 Thread Yu Chen
Hi Dave, On Tue, Nov 14, 2017 at 09:52:16AM +1100, Dave Chinner wrote: > On Mon, Nov 13, 2017 at 06:31:39PM +0800, Yu Chen wrote: > > Hi all, > > Currently we are running hibernation stress test on a server > > and unfortunately after 48 rounds of cycling, it fails at a > > early stage that, the xf

Re: [Regression/XFS/PM] Freeze tasks failed in xfsaild

2017-11-13 Thread Yu Chen
On Mon, Nov 13, 2017 at 09:14:14PM +0100, Luis R. Rodriguez wrote: > On Mon, Nov 13, 2017 at 06:31:39PM +0800, Yu Chen wrote: > > The xfs-buf/dm-1 should be freezed according to > > commit 8018ec083c72 ("xfs: mark all internal workqueues > > as freezable"), thus a easier way might be have to revert