Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-19 Thread Joerg Roedel
On Wed, Mar 16, 2016 at 05:17:37PM +0100, Luis R. Rodriguez wrote: > On Wed, Mar 16, 2016 at 12:16:57PM +0200, Oded Gabbay wrote: > > In theory it should, but I would prefer that it would be tested on > > actual hardware. > > Hence, RFT. Anyone have hardware to test ? And would the other hack > me

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-19 Thread Luis R. Rodriguez
On Wed, Mar 16, 2016 at 05:39:00PM +0100, Joerg Roedel wrote: > On Wed, Mar 16, 2016 at 05:17:37PM +0100, Luis R. Rodriguez wrote: > > On Wed, Mar 16, 2016 at 12:16:57PM +0200, Oded Gabbay wrote: > > > In theory it should, but I would prefer that it would be tested on > > > actual hardware. > > >

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-18 Thread Joerg Roedel
On Wed, Mar 16, 2016 at 05:57:47PM +0100, Luis R. Rodriguez wrote: > I'm afraid I am not sure where that hack is, can someone construct a patch to > revert that so this is a proper RFT series ? Oded mentioned 1bacc894c227fad8a727eb99728df708eba57654, which reverts fine here on v4.5. Joer

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-18 Thread Luis R. Rodriguez
On Wed, Mar 16, 2016 at 12:16:57PM +0200, Oded Gabbay wrote: > On Wed, Mar 16, 2016 at 12:14 PM, Joerg Roedel wrote: > > On Wed, Mar 16, 2016 at 09:02:43AM +0200, Oded Gabbay wrote: > >> fwiw, we currently have this covered by the ugly hack of putting iommu > >> subsystem in front of gpu subsystem

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-16 Thread Oded Gabbay
On Wed, Mar 16, 2016 at 12:14 PM, Joerg Roedel wrote: > On Wed, Mar 16, 2016 at 09:02:43AM +0200, Oded Gabbay wrote: >> fwiw, we currently have this covered by the ugly hack of putting iommu >> subsystem in front of gpu subsystem in the main drivers makefile (See >> 1bacc894c227fad8a727eb99728df70

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-16 Thread Joerg Roedel
On Wed, Mar 16, 2016 at 09:02:43AM +0200, Oded Gabbay wrote: > fwiw, we currently have this covered by the ugly hack of putting iommu > subsystem in front of gpu subsystem in the main drivers makefile (See > 1bacc894c227fad8a727eb99728df708eba57654) Sure, but the above is a less ugly hack to solve

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-16 Thread Oded Gabbay
On Wed, Mar 16, 2016 at 12:12 AM, Luis R. Rodriguez wrote: > We need to ensure amd iommu v2 initializes before > driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, > to do this make its init routine a subsys_initcall() which > ensures its load init is called first than modules when > bui

[RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-15 Thread Luis R. Rodriguez
We need to ensure amd iommu v2 initializes before driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, to do this make its init routine a subsys_initcall() which ensures its load init is called first than modules when built-in. Signed-off-by: Luis R. Rodriguez --- Can someone test if thi