Re: [RFCv2][PATCH 1/7] fs: optimize inotify/fsnotify code for unwatched files

2015-06-25 Thread Dave Hansen
On 06/24/2015 05:57 PM, Eric Paris wrote: > On Wed, 2015-06-24 at 17:16 -0700, Dave Hansen wrote: >> +if (!to_tell->i_fsnotify_marks.first && >> +(!mnt || !mnt->mnt_fsnotify_marks.first)) >> +return 0; > > two useless peeps from the old peanut gallery of long lost > >

Re: [RFCv2][PATCH 1/7] fs: optimize inotify/fsnotify code for unwatched files

2015-06-24 Thread Eric Paris
On Wed, 2015-06-24 at 17:16 -0700, Dave Hansen wrote: > From: Dave Hansen > > I have a _tiny_ microbenchmark that sits in a loop and writes > single bytes to a file. Writing one byte to a tmpfs file is > around 2x slower than reading one byte from a file, which is a > _bit_ more than I expecte.

[RFCv2][PATCH 1/7] fs: optimize inotify/fsnotify code for unwatched files

2015-06-24 Thread Dave Hansen
From: Dave Hansen I have a _tiny_ microbenchmark that sits in a loop and writes single bytes to a file. Writing one byte to a tmpfs file is around 2x slower than reading one byte from a file, which is a _bit_ more than I expecte. This is a dumb benchmark, but I think it's hard to deny that wri