Re: [RFCv2,2/2] i2c: add new dual Flash driver,LM3646

2014-01-29 Thread Sakari Ailus
Hi Daniel, Thanks for the update. The driver is very nicely written in general btw. One comment below. On Tue, Jan 28, 2014 at 03:55:58PM +0900, Daniel Jeong wrote: ... > +/* > + * struct lm3646_flash > + * > + * @pdata: platform data > + * @regmap: reg. map for i2c > + * @lock: muxtex for serial

Re: [RFCv2,2/2] i2c: add new dual Flash driver,LM3646

2014-01-27 Thread Hans Verkuil
On 01/28/2014 07:55 AM, Daniel Jeong wrote: > Add new dual flash driver. > LM3646 is a dual Flash LED Driver, LED1 and LED2, following the datasheet. > But there is no registers to contorl LED2 brightness. > LED2 brightness can be controlled by limiting max brightness. > LED2 brightness = Total b

[RFCv2,2/2] i2c: add new dual Flash driver,LM3646

2014-01-27 Thread Daniel Jeong
Add new dual flash driver. LM3646 is a dual Flash LED Driver, LED1 and LED2, following the datasheet. But there is no registers to contorl LED2 brightness. LED2 brightness can be controlled by limiting max brightness. LED2 brightness = Total brightness - LED1 brightness LED2 will be off if LED2 b