Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-20 Thread Brian Starkey
On Fri, Nov 17, 2017 at 11:19:05AM -0200, Mauro Carvalho Chehab wrote: Em Fri, 17 Nov 2017 11:08:01 -0200 Gustavo Padovan escreveu: 2017-11-17 Mauro Carvalho Chehab : > Em Fri, 17 Nov 2017 15:49:23 +0900 > Alexandre Courbot escreveu: > > > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepa

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-19 Thread Alexandre Courbot
On Fri, Nov 17, 2017 at 10:01 PM, Gustavo Padovan wrote: > 2017-11-17 Alexandre Courbot : > >> Hi Gustavo, >> >> I am coming a bit late in this series' review, so apologies if some of my >> comments have already have been discussed in an earlier revision. >> >> On Thursday, November 16, 2017 2:10:

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-18 Thread Hans Verkuil
On 17/11/17 18:40, Gustavo Padovan wrote: > 2017-11-17 Hans Verkuil : > >> On 15/11/17 18:10, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Receive in-fence from userspace and add support for waiting on them >>> before queueing the buffer to the driver. Buffers can't be queued to the >

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Gustavo Padovan : > 2017-11-17 Hans Verkuil : > > > On 15/11/17 18:10, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Receive in-fence from userspace and add support for waiting on them > > > before queueing the buffer to the driver. Buffers can't be queued to the > >

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Hans Verkuil : > On 15/11/17 18:10, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queued to the > > driver before its fences signal. And a buff

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Mauro Carvalho Chehab : > Em Fri, 17 Nov 2017 11:12:48 -0200 > Gustavo Padovan escreveu: > > > > > /* > > > > * If streamon has been called, and we haven't yet called > > > > * start_streaming() since not enough buffers were queued, and > > > > * we

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Hans Verkuil
On 15/11/17 18:10, Gustavo Padovan wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer can't be queue to the driver > out o

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Nov 2017 11:12:48 -0200 Gustavo Padovan escreveu: > > > /* > > >* If streamon has been called, and we haven't yet called > > >* start_streaming() since not enough buffers were queued, and > > >* we now have reached the minimum number of queued buffers, > > >* then we

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Nov 2017 11:08:01 -0200 Gustavo Padovan escreveu: > 2017-11-17 Mauro Carvalho Chehab : > > > Em Fri, 17 Nov 2017 15:49:23 +0900 > > Alexandre Courbot escreveu: > > > > > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepare_buf(struct > > > > vb2_queue *q, struct v4l2_buffer *b,

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Mauro Carvalho Chehab : > Em Wed, 15 Nov 2017 15:10:53 -0200 > Gustavo Padovan escreveu: > > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queued to the > > driver be

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Mauro Carvalho Chehab : > Em Fri, 17 Nov 2017 15:49:23 +0900 > Alexandre Courbot escreveu: > > > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepare_buf(struct > > > vb2_queue *q, struct v4l2_buffer *b, > > > return -EINVAL; > > > } > > > > > > + if ((b->fence_fd !=

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Gustavo Padovan
2017-11-17 Alexandre Courbot : > Hi Gustavo, > > I am coming a bit late in this series' review, so apologies if some of my > comments have already have been discussed in an earlier revision. > > On Thursday, November 16, 2017 2:10:53 AM JST, Gustavo Padovan wrote: > > From: Gustavo Padovan > >

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Nov 2017 15:49:23 +0900 Alexandre Courbot escreveu: > > @@ -178,6 +179,12 @@ static int vb2_queue_or_prepare_buf(struct > > vb2_queue *q, struct v4l2_buffer *b, > > return -EINVAL; > > } > > > > + if ((b->fence_fd != 0 && b->fence_fd != -1) && > > Why do we need

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-17 Thread Mauro Carvalho Chehab
Em Wed, 15 Nov 2017 15:10:53 -0200 Gustavo Padovan escreveu: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer can't be queue

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-16 Thread Alexandre Courbot
Hi Gustavo, I am coming a bit late in this series' review, so apologies if some of my comments have already have been discussed in an earlier revision. On Thursday, November 16, 2017 2:10:53 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support f

[RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-15 Thread Gustavo Padovan
From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't be queue to the driver out of the order they were queued from userspace. That mean