Re: [RFC v2 2/7] user_ns: use new hashtable implementation

2012-08-04 Thread Eric W. Biederman
Sasha Levin writes: > Switch user_ns to use the new hashtable implementation. This reduces the > amount of > generic unrelated code in user_ns. Just looking at this ick. - Your comparison function is broken. - The naming is awkward. hash_get without a reference count being incremented? -

[RFC v2 2/7] user_ns: use new hashtable implementation

2012-08-03 Thread Sasha Levin
Switch user_ns to use the new hashtable implementation. This reduces the amount of generic unrelated code in user_ns. Signed-off-by: Sasha Levin --- kernel/user.c | 53 ++--- 1 files changed, 18 insertions(+), 35 deletions(-) diff --git a/kerne