Re: [RFC v2 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2015-11-05 Thread Philipp Zabel
Hi Jitao, some things I missed before. Am Montag, den 02.11.2015, 10:09 +0800 schrieb Jitao Shi: [...] > +static int ps8640_regr(struct i2c_client *client, u16 i2c_addr, > +u8 reg, u8 *value) > +{ > + int ret; > + > + client->addr = i2c_addr; I think i2c_new_dummy sho

Re: [RFC v2 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2015-11-04 Thread jitao shi
Hi Philipp I'll fixed those comments on V3. Thank you very much. Best Regards. On Mon, 2015-11-02 at 12:34 +0100, Philipp Zabel wrote: > Hi Jitao, > > a few comments below. > > Am Montag, den 02.11.2015, 11:54 +0800 schrieb jitao shi: > [...] > > > +static int ps8640_check_valid_id(struct ps8

Re: [RFC v2 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2015-11-02 Thread Philipp Zabel
Hi Jitao, a few comments below. Am Montag, den 02.11.2015, 11:54 +0800 schrieb jitao shi: [...] > > +static int ps8640_check_valid_id(struct ps8640 *ps_bridge) This could be bool and return true/false. > > +{ > > + struct i2c_client *client = ps_bridge->client; > > + u8 rev_id_low, rev_id_h

Re: [RFC v2 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2015-11-01 Thread jitao shi
On Mon, 2015-11-02 at 10:09 +0800, Jitao Shi wrote: > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi --- changes since v1: 1. remove edid code 2. remove some wrong comments 3. tune some gpios name, make it easy understand

[RFC v2 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2015-11-01 Thread Jitao Shi
This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi --- drivers/gpu/drm/bridge/Kconfig |9 + drivers/gpu/drm/bridge/Makefile|1 + drivers/gpu/drm/bridge/parade-ps8640.c | 479 3 files changed, 489