Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-11 Thread Peter Seiderer
Hello Mark, On Mon, 11 Feb 2019 15:04:25 +, Mark Brown wrote: > On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote: > > > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct > > snd_soc_component *component) > > gpio_set_value(aic32x4->rstn_gpio, 1); > >

Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-11 Thread Mark Brown
On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote: > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct > snd_soc_component *component) > gpio_set_value(aic32x4->rstn_gpio, 1); > } > > + mdelay(1); > + Perhaps only do this if we toggled the GPIO?

[RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

2019-02-10 Thread Peter Seiderer
As stated in 'TLV320AIC3254 Application Reference Guide' ([1]): 3.2 Device Startup Lockout Times After the TLV320AIC3254 initializes through hardware reset at power-up or software reset, the internal registers initialize to default values. This initialization takes place within 1ms a