Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

2016-02-26 Thread Holger Schurig
Pankaj DEV writes: > The prime motive for clk_set_rate is to set new rate for a clock, > since the 'clk_rate' currently available, allows only reading. > To provide reading rate from 'clk_set_rate' is just additional feature. Sure. But my point is to combine things. After your patch: - read

RE: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

2016-02-26 Thread Pankaj DEV
...@linaro.org; Maxime >COQUELIN >Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set- >parent > >Pankaj Dev writes: > >> 1. clk_set_rate : Set new rate to value. Reading returns the current >> rate > >If you can use this to set *and* read

Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

2016-02-25 Thread Holger Schurig
Pankaj Dev writes: > 1. clk_set_rate : Set new rate to value. Reading returns the > current rate If you can use this to set *and* read it, then "_set_" shouldn't be in the name. What is wrong with using the existing "clk_rate" for reading/setting the rate?

[RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

2016-02-25 Thread Pankaj Dev
To enhance debug interface for clocks, we add the following interfaces to the clock nodes created at /sys/kernel/debug/clk/CLOCK_NAME 1. clk_set_rate : Set new rate to value. Reading returns the current rate 2. clk_set_parent : Set new parent to parent-name. Reading returns the current parent 3. c