Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-21 Thread Zach Brown
On Tue, May 21, 2013 at 07:47:19PM +, Eric Wong wrote: > Zach Brown wrote: > > On Wed, May 15, 2013 at 07:44:05PM +, Eric Wong wrote: > > > Why introduce a new syscall instead of extending sys_splice? > > > > Personally, I think it's ugly to have different operations use the same > > sysc

Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-21 Thread Eric Wong
Zach Brown wrote: > On Wed, May 15, 2013 at 07:44:05PM +, Eric Wong wrote: > > Why introduce a new syscall instead of extending sys_splice? > > Personally, I think it's ugly to have different operations use the same > syscall just because their arguments match. Fair enough. I think adding a

Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-16 Thread Ric Wheeler
On 05/15/2013 04:03 PM, Zach Brown wrote: On Wed, May 15, 2013 at 07:44:05PM +, Eric Wong wrote: Why introduce a new syscall instead of extending sys_splice? Personally, I think it's ugly to have different operations use the same syscall just because their arguments match. I agree with Za

Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-15 Thread Zach Brown
On Wed, May 15, 2013 at 07:44:05PM +, Eric Wong wrote: > Why introduce a new syscall instead of extending sys_splice? Personally, I think it's ugly to have different operations use the same syscall just because their arguments match. But that preference aside, sure, if the consensus is that w

Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-15 Thread Eric Wong
Zach Brown wrote: > This adds a syscall and vfs entry point for clone_range which offloads > data copying between existing files. > > The syscall is a thin wrapper around the vfs entry point. Its arguments > are inspired by sys_splice(). Why introduce a new syscall instead of extending sys_spli

[RFC v0 1/4] vfs: add copy_range syscall and vfs entry point

2013-05-14 Thread Zach Brown
This adds a syscall and vfs entry point for clone_range which offloads data copying between existing files. The syscall is a thin wrapper around the vfs entry point. Its arguments are inspired by sys_splice(). The behaviour of the vfs helper is derived from the current btrfs CLONE_RANGE ioctl. -