Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Joe Damato
On Mon, Jan 27, 2025 at 02:24:00PM -0800, Jakub Kicinski wrote: > On Mon, 27 Jan 2025 17:07:54 -0500 Joe Damato wrote: > > > Tx NAPIs are one aspect, whether they have ID or not we may want direct > > > access to the struct somewhere in the core, via txq, at some point, and > > > then people may fo

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Jakub Kicinski
On Mon, 27 Jan 2025 17:07:54 -0500 Joe Damato wrote: > > Tx NAPIs are one aspect, whether they have ID or not we may want direct > > access to the struct somewhere in the core, via txq, at some point, and > > then people may forget the linking has an unintended effect of also > > changing the netli

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Joe Damato
On Mon, Jan 27, 2025 at 01:33:04PM -0800, Jakub Kicinski wrote: > On Mon, 27 Jan 2025 14:31:21 -0500 Joe Damato wrote: > > Actually, I missed a patch Jakub submit to net [1], which prevents > > dumping TX-only NAPIs. > > That patch only addresses NAPI ops, here I think we're talking about > attrib

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Jakub Kicinski
On Mon, 27 Jan 2025 14:31:21 -0500 Joe Damato wrote: > Actually, I missed a patch Jakub submit to net [1], which prevents > dumping TX-only NAPIs. That patch only addresses NAPI ops, here I think we're talking about attributes of the queue object. > So, I think this RFC as-is (only calling netif_

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Joe Damato
On Mon, Jan 27, 2025 at 12:52:06PM -0500, Joe Damato wrote: > On Sun, Jan 26, 2025 at 04:04:02PM +0800, Jason Wang wrote: > > On Sat, Jan 25, 2025 at 4:19 AM Joe Damato wrote: > > > > > > On Fri, Jan 24, 2025 at 09:14:54AM +0800, Jason Wang wrote: > > > > On Thu, Jan 23, 2025 at 10:47 AM Joe Damat

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-27 Thread Joe Damato
On Sun, Jan 26, 2025 at 04:04:02PM +0800, Jason Wang wrote: > On Sat, Jan 25, 2025 at 4:19 AM Joe Damato wrote: > > > > On Fri, Jan 24, 2025 at 09:14:54AM +0800, Jason Wang wrote: > > > On Thu, Jan 23, 2025 at 10:47 AM Joe Damato wrote: > > > > > > > > On Thu, Jan 23, 2025 at 10:40:43AM +0800, Ja

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-26 Thread Jason Wang
On Sat, Jan 25, 2025 at 4:19 AM Joe Damato wrote: > > On Fri, Jan 24, 2025 at 09:14:54AM +0800, Jason Wang wrote: > > On Thu, Jan 23, 2025 at 10:47 AM Joe Damato wrote: > > > > > > On Thu, Jan 23, 2025 at 10:40:43AM +0800, Jason Wang wrote: > > > > On Thu, Jan 23, 2025 at 1:41 AM Joe Damato wrot

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-24 Thread Joe Damato
On Fri, Jan 24, 2025 at 09:14:54AM +0800, Jason Wang wrote: > On Thu, Jan 23, 2025 at 10:47 AM Joe Damato wrote: > > > > On Thu, Jan 23, 2025 at 10:40:43AM +0800, Jason Wang wrote: > > > On Thu, Jan 23, 2025 at 1:41 AM Joe Damato wrote: > > > > > > > > On Wed, Jan 22, 2025 at 02:12:46PM +0800, Ja

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-23 Thread Jason Wang
On Thu, Jan 23, 2025 at 10:47 AM Joe Damato wrote: > > On Thu, Jan 23, 2025 at 10:40:43AM +0800, Jason Wang wrote: > > On Thu, Jan 23, 2025 at 1:41 AM Joe Damato wrote: > > > > > > On Wed, Jan 22, 2025 at 02:12:46PM +0800, Jason Wang wrote: > > > > On Wed, Jan 22, 2025 at 3:11 AM Joe Damato wrot

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-22 Thread Joe Damato
On Thu, Jan 23, 2025 at 10:40:43AM +0800, Jason Wang wrote: > On Thu, Jan 23, 2025 at 1:41 AM Joe Damato wrote: > > > > On Wed, Jan 22, 2025 at 02:12:46PM +0800, Jason Wang wrote: > > > On Wed, Jan 22, 2025 at 3:11 AM Joe Damato wrote: > > > > > > > > Slight refactor to prepare the code for NAPI

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-22 Thread Jason Wang
On Thu, Jan 23, 2025 at 1:41 AM Joe Damato wrote: > > On Wed, Jan 22, 2025 at 02:12:46PM +0800, Jason Wang wrote: > > On Wed, Jan 22, 2025 at 3:11 AM Joe Damato wrote: > > > > > > Slight refactor to prepare the code for NAPI to queue mapping. No > > > functional changes. > > > > > > Signed-off-by

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-22 Thread Joe Damato
On Wed, Jan 22, 2025 at 02:12:46PM +0800, Jason Wang wrote: > On Wed, Jan 22, 2025 at 3:11 AM Joe Damato wrote: > > > > Slight refactor to prepare the code for NAPI to queue mapping. No > > functional changes. > > > > Signed-off-by: Joe Damato > > Reviewed-by: Gerhard Engleder > > Tested-by: Lei

Re: [RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-21 Thread Jason Wang
On Wed, Jan 22, 2025 at 3:11 AM Joe Damato wrote: > > Slight refactor to prepare the code for NAPI to queue mapping. No > functional changes. > > Signed-off-by: Joe Damato > Reviewed-by: Gerhard Engleder > Tested-by: Lei Yang > --- > v2: >- Previously patch 1 in the v1. >- Added Review

[RFC net-next v3 2/4] virtio_net: Prepare for NAPI to queue mapping

2025-01-21 Thread Joe Damato
Slight refactor to prepare the code for NAPI to queue mapping. No functional changes. Signed-off-by: Joe Damato Reviewed-by: Gerhard Engleder Tested-by: Lei Yang --- v2: - Previously patch 1 in the v1. - Added Reviewed-by and Tested-by tags to commit message. No functional changes.