Re: [RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-20 Thread Anshuman Khandual
On 05/20/2020 12:45 PM, HORIGUCHI NAOYA(堀口　直也) wrote: > On Mon, May 18, 2020 at 12:12:36PM +0530, Anshuman Khandual wrote: >> This adds the following two new VM events which will help in validating PMD >> based THP migration without split. Statistics reported through these events >> will help in

Re: [RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-20 Thread 堀口　直也
On Mon, May 18, 2020 at 12:12:36PM +0530, Anshuman Khandual wrote: > This adds the following two new VM events which will help in validating PMD > based THP migration without split. Statistics reported through these events > will help in performance debugging. > > 1. THP_PMD_MIGRATION_SUCCESS > 2.

Re: [RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-19 Thread John Hubbard
On 2020-05-19 20:32, Anshuman Khandual wrote: ... How about not being quite so granular on the THP config options, and just guarding these events with the overall CONFIG_TRANSPARENT_HUGEPAGE option, instead of the sub-option CONFIG_ARCH_ENABLE_THP_MIGRATION? I tentatively think it's harmless and

Re: [RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-19 Thread Anshuman Khandual
On 05/19/2020 01:40 AM, John Hubbard wrote: > On 2020-05-17 23:42, Anshuman Khandual wrote: > ... >> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h >> index ffef0f279747..23d8f9884c2b 100644 >> --- a/include/linux/vm_event_item.h >> +++ b/include/linux/vm_event_item.h

Re: [RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-18 Thread John Hubbard
On 2020-05-17 23:42, Anshuman Khandual wrote: ... diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h index ffef0f279747..23d8f9884c2b 100644 --- a/include/linux/vm_event_item.h +++ b/include/linux/vm_event_item.h @@ -91,6 +91,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSW

[RFC V2] mm/vmstat: Add events for PMD based THP migration without split

2020-05-17 Thread Anshuman Khandual
This adds the following two new VM events which will help in validating PMD based THP migration without split. Statistics reported through these events will help in performance debugging. 1. THP_PMD_MIGRATION_SUCCESS 2. THP_PMD_MIGRATION_FAILURE Cc: Naoya Horiguchi Cc: Zi Yan Cc: John Hubbard