On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
+static int __init vmd_init(void)
+{
+ return pci_register_driver(&vmd_drv);
+}
+module_init(vmd_init);
module_pci_driver(vmd_drv)?
We actually only have a module_init in this driver, and purposely left
out module_exit. We don't want to be able t
On Wed, Oct 07, 2015 at 12:21:02AM +, Keith Busch wrote:
> Hi Bjorn,
>
> Thanks for the feedback. Much of the issues you mentioned look pretty
> straight forward to resolve, and will fix of for the next revision.
>
> I have some immediate follow up comments to two issues you brought up:
>
>
On Wed, Oct 07, 2015 at 04:04:07PM +, Keith Busch wrote:
> On Tue, 6 Oct 2015, Keith Busch wrote:
> >On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
> >>>+ resource_list_for_each_entry(entry, &resources) {
> >>>+ struct resource *source, *resource = entry->res;
> >>>+
> >>>+ if (!i)
On Tue, 6 Oct 2015, Keith Busch wrote:
On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
+ resource_list_for_each_entry(entry, &resources) {
+ struct resource *source, *resource = entry->res;
+
+ if (!i) {
+ resource->start = 0;
+
Hi Bjorn,
Thanks for the feedback. Much of the issues you mentioned look pretty
straight forward to resolve, and will fix of for the next revision.
I have some immediate follow up comments to two issues you brought up:
On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
+static int vmd_find_free_domain(v
Hi Keith,
I have a few comments scattered below.
On Thu, Oct 01, 2015 at 11:44:14AM -0600, Keith Busch wrote:
> The Intel Volume Management Device (VMD) is an integrated endpoint on the
> platform's PCIe root complex that acts as a host bridge to a secondary
> PCIe domain. BIOS can reassign one o
On Mon, 5 Oct 2015, Ingo Molnar wrote:
* Keith Busch wrote:
The immediate benefit is that devices on VMD domains do not use resources
on the default PCI domain, so we have more than the 256 buses available.
Would be nice to incorporate that information in the help text and in the
changelog.
* Keith Busch wrote:
> On Sat, 3 Oct 2015, Ingo Molnar wrote:
> >* Keith Busch wrote:
> >>+config VMDDEV
> >>+ depends on PCI && PCI_DOMAINS && PCI_MSI && GENERIC_MSI_IRQ_DOMAIN &&
> >>IRQ_DOMAIN_HIERARCHY
> >>+ tristate "Volume Management Device Driver"
> >>+ default N
> >>+ select HA
On Sat, 3 Oct 2015, Ingo Molnar wrote:
* Keith Busch wrote:
+config VMDDEV
+ depends on PCI && PCI_DOMAINS && PCI_MSI && GENERIC_MSI_IRQ_DOMAIN &&
IRQ_DOMAIN_HIERARCHY
+ tristate "Volume Management Device Driver"
+ default N
+ select HAVE_VMDDEV
+ ---help---
+
Hi Keith,
[auto build test results on v4.3-rc3 -- if it's inappropriate base, please
ignore]
config: i386-randconfig-h1-10040721 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file i
* Keith Busch wrote:
> +config VMDDEV
> + depends on PCI && PCI_DOMAINS && PCI_MSI && GENERIC_MSI_IRQ_DOMAIN &&
> IRQ_DOMAIN_HIERARCHY
> + tristate "Volume Management Device Driver"
> + default N
> + select HAVE_VMDDEV
> + ---help---
> + Adds support for the Intel Volume
The Intel Volume Management Device (VMD) is an integrated endpoint on the
platform's PCIe root complex that acts as a host bridge to a secondary
PCIe domain. BIOS can reassign one or more root ports to appear within
a VMD domain instead of the primary domain.
This driver enumerates and enables the
12 matches
Mail list logo
