Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-08 Thread Jason Wang
On Thu, Aug 8, 2024 at 10:56 AM Jason Wang wrote: > > On Tue, Aug 6, 2024 at 10:45 PM Dragos Tatulea wrote: > > > > > > > > On 06.08.24 10:18, Dragos Tatulea wrote: > > > (Re-sending. I messed up the previous message, sorry about that.) > > > > > > On 06.08.24 04:57, Jason Wang wrote: > > >> On M

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-07 Thread Jason Wang
On Tue, Aug 6, 2024 at 10:45 PM Dragos Tatulea wrote: > > > > On 06.08.24 10:18, Dragos Tatulea wrote: > > (Re-sending. I messed up the previous message, sorry about that.) > > > > On 06.08.24 04:57, Jason Wang wrote: > >> On Mon, Aug 5, 2024 at 11:59 PM Dragos Tatulea wrote: > >>> > >>> On 05.08

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-06 Thread Dragos Tatulea
On 06.08.24 10:18, Dragos Tatulea wrote: > (Re-sending. I messed up the previous message, sorry about that.) > > On 06.08.24 04:57, Jason Wang wrote: >> On Mon, Aug 5, 2024 at 11:59 PM Dragos Tatulea wrote: >>> >>> On 05.08.24 05:17, Jason Wang wrote: On Fri, Aug 2, 2024 at 2:51 PM Dragos

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-06 Thread Dragos Tatulea
(Re-sending. I messed up the previous message, sorry about that.) On 06.08.24 04:57, Jason Wang wrote: > On Mon, Aug 5, 2024 at 11:59 PM Dragos Tatulea wrote: >> >> On 05.08.24 05:17, Jason Wang wrote: >>> On Fri, Aug 2, 2024 at 2:51 PM Dragos Tatulea wrote: On Fri, 2024-08-02 at 11:29

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-05 Thread Jason Wang
On Mon, Aug 5, 2024 at 11:59 PM Dragos Tatulea wrote: > > On 05.08.24 05:17, Jason Wang wrote: > > On Fri, Aug 2, 2024 at 2:51 PM Dragos Tatulea wrote: > >> > >> On Fri, 2024-08-02 at 11:29 +0800, Jason Wang wrote: > >>> On Thu, Aug 1, 2024 at 11:38 PM Dragos Tatulea > >>> wrote: > >

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-05 Thread Dragos Tatulea
On 05.08.24 05:17, Jason Wang wrote: > On Fri, Aug 2, 2024 at 2:51 PM Dragos Tatulea wrote: >> >> On Fri, 2024-08-02 at 11:29 +0800, Jason Wang wrote: >>> On Thu, Aug 1, 2024 at 11:38 PM Dragos Tatulea wrote: The following workflow triggers the crash referenced below: 1) vhost

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-04 Thread Jason Wang
On Fri, Aug 2, 2024 at 2:51 PM Dragos Tatulea wrote: > > On Fri, 2024-08-02 at 11:29 +0800, Jason Wang wrote: > > On Thu, Aug 1, 2024 at 11:38 PM Dragos Tatulea wrote: > > > > > > The following workflow triggers the crash referenced below: > > > > > > 1) vhost_vdpa_unsetup_vq_irq() unregisters th

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-01 Thread Dragos Tatulea
On Fri, 2024-08-02 at 11:29 +0800, Jason Wang wrote: > On Thu, Aug 1, 2024 at 11:38 PM Dragos Tatulea wrote: > > > > The following workflow triggers the crash referenced below: > > > > 1) vhost_vdpa_unsetup_vq_irq() unregisters the irq bypass producer > >but the producer->token is still vali

Re: [RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-01 Thread Jason Wang
On Thu, Aug 1, 2024 at 11:38 PM Dragos Tatulea wrote: > > The following workflow triggers the crash referenced below: > > 1) vhost_vdpa_unsetup_vq_irq() unregisters the irq bypass producer >but the producer->token is still valid. > 2) vq context gets released and reassigned to another vq. Jus

[RFC PATCH vhost] vhost-vdpa: Fix invalid irq bypass unregister

2024-08-01 Thread Dragos Tatulea
The following workflow triggers the crash referenced below: 1) vhost_vdpa_unsetup_vq_irq() unregisters the irq bypass producer but the producer->token is still valid. 2) vq context gets released and reassigned to another vq. 3) That other vq registers it's producer with the same vq context p