Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-29 Thread Javi Merino
On Thu, Jan 29, 2015 at 12:15:07AM +, Eduardo Valentin wrote: > > Hi Eduardo, > > > > Eduardo Valentin writes: > > > > > Hello Javi, > > > > > > On Fri, Dec 05, 2014 at 07:04:17PM +, Javi Merino wrote: > > >> Add a basic power model to the cpu cooling device to implement the > > >> power

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-29 Thread Eduardo Valentin
:x > Hi Eduardo, > > Eduardo Valentin writes: > > > Hello Javi, > > > > On Fri, Dec 05, 2014 at 07:04:17PM +, Javi Merino wrote: > >> Add a basic power model to the cpu cooling device to implement the > >> power cooling device API. The power model uses the current frequency, > >> current lo

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-29 Thread Punit Agrawal
Hi Eduardo, Eduardo Valentin writes: > Hello Javi, > > On Fri, Dec 05, 2014 at 07:04:17PM +, Javi Merino wrote: >> Add a basic power model to the cpu cooling device to implement the >> power cooling device API. The power model uses the current frequency, >> current load and OPPs for the pow

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-28 Thread Eduardo Valentin
Hello Javi, On Fri, Dec 05, 2014 at 07:04:17PM +, Javi Merino wrote: > Add a basic power model to the cpu cooling device to implement the > power cooling device API. The power model uses the current frequency, > current load and OPPs for the power calculations. The cpus must have > register

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-06 Thread Javi Merino
Hi Eduardo, On Mon, Jan 05, 2015 at 08:44:53PM +, Eduardo Valentin wrote: > On Mon, Jan 05, 2015 at 04:53:40PM +, Javi Merino wrote: > > On Fri, Jan 02, 2015 at 02:37:23PM +, Eduardo Valentin wrote: > > > On Tue, Dec 09, 2014 at 11:00:43AM +, Javi Merino wrote: > > > > On Tue, Dec

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-05 Thread Eduardo Valentin
Javi, On Mon, Jan 05, 2015 at 04:53:40PM +, Javi Merino wrote: > On Fri, Jan 02, 2015 at 02:37:23PM +, Eduardo Valentin wrote: > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > Hello Javi, > > > > Looks

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-05 Thread Javi Merino
On Fri, Jan 02, 2015 at 02:37:23PM +, Eduardo Valentin wrote: > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > Hello Javi, > > Looks like the charset seams to be scrambled. Anyways, I will attempt to > send a couple o

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2015-01-02 Thread Eduardo Valentin
Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Javi, Looks like the charset seams to be scrambled. Anyways, I will attempt to send a couple of feedback here.. On Tue, Dec 09, 2014 at 11:00:43AM +, Javi Merino wrote: >

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
On Tue, Dec 09, 2014 at 11:06:46AM +, Viresh Kumar wrote: > On 9 December 2014 at 16:30, Javi Merino wrote: > > Ok, how about this then? I've pasted the whole commit so as to avoid > > confusion. > > Yeah, the cpu_dev part looks fine now. Great, thanks! -- To unsubscribe from this list: se

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Viresh Kumar
On 9 December 2014 at 16:30, Javi Merino wrote: > Ok, how about this then? I've pasted the whole commit so as to avoid > confusion. Yeah, the cpu_dev part looks fine now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
On Tue, Dec 09, 2014 at 10:36:46AM +, Viresh Kumar wrote: > On 9 December 2014 at 16:02, Javi Merino wrote: > > Sorry but I don't follow. __cpufreq_cooling_register() is passed a > > clip_cpus mask, not a single cpu. How do I get "the cpu for which > > __cpufreq_cooling_register() is called"

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Viresh Kumar
On 9 December 2014 at 16:02, Javi Merino wrote: > Sorry but I don't follow. __cpufreq_cooling_register() is passed a > clip_cpus mask, not a single cpu. How do I get "the cpu for which > __cpufreq_cooling_register() is called" if not by looping through all > the cpus in the mask? Yeah, its np t

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-09 Thread Javi Merino
Hi Viresh, On Tue, Dec 09, 2014 at 01:59:39AM +, Viresh Kumar wrote: > On 8 December 2014 at 19:52, Javi Merino wrote: > > Ok, changed it into: > > > > cpu = cpumask_any(&cpufreq_device->allowed_cpus); > > dev = get_cpu_device(cpu); > > if (!dev) { > >

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Viresh Kumar
On 8 December 2014 at 19:52, Javi Merino wrote: > Ok, changed it into: > > cpu = cpumask_any(&cpufreq_device->allowed_cpus); > dev = get_cpu_device(cpu); > if (!dev) { > dev_warn(&cpufreq_device->cool_dev->device, > "No cpu device for

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Javi Merino
On Mon, Dec 08, 2014 at 01:31:35PM +, Viresh Kumar wrote: > On 8 December 2014 at 18:20, Javi Merino wrote: > > Is this loop pointless? I seem to recall that it was needed but I > > forgot the details. If you think it is, I can remove it. > > Yes it is pointless. The CPUs you are iterating

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Viresh Kumar
On 8 December 2014 at 18:20, Javi Merino wrote: > Sigh. Care to share them (privately I guess)? Sure, you will get that in a separate (private) mail.. > Is this loop pointless? I seem to recall that it was needed but I > forgot the details. If you think it is, I can remove it. Yes it is poin

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-08 Thread Javi Merino
On Mon, Dec 08, 2014 at 05:49:00AM +, Viresh Kumar wrote: > Hi Javi, Hi Viresh, > Looks like ARM's exchange server screwed up your patch? > > This is how I see it with gmail's show-original option: > > +=09cpufreq_device->dyn_power_table =3D power_table; > +=09cpufreq_device->dyn_power_tabl

Re: [RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-07 Thread Viresh Kumar
Hi Javi, Looks like ARM's exchange server screwed up your patch? This is how I see it with gmail's show-original option: +=09cpufreq_device->dyn_power_table =3D power_table; +=09cpufreq_device->dyn_power_table_entries =3D i; + I have seen this a lot, while I was in ARM. Had to adopt some work-a

[RFC PATCH v6 6/9] thermal: cpu_cooling: implement the power cooling device API

2014-12-05 Thread Javi Merino
Add a basic power model to the cpu cooling device to implement the power cooling device API. The power model uses the current frequency, current load and OPPs for the power calculations. The cpus must have registered their OPPs using the OPP library. Cc: Zhang Rui Cc: Eduardo Valentin Signed-o