Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-25 Thread Maxime Ripard
Hi, On Wed, Jun 24, 2015 at 10:34:43AM +0100, Srinivas Kandagatla wrote: > > > On 24/06/15 09:35, Maxime Ripard wrote: > >Hi, > > > >On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote: > >>+static struct nvmem_config ocotp_config = { > >>+ .name = "soc_id", > >>+}; > >>+ > >>+stat

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread maitysanchayan
Hello Stefan, On 15-06-24 13:52:28, Stefan Wahren wrote: > Hi Srinivas, > > Am 24.06.2015 um 12:45 schrieb maitysancha...@gmail.com: > > Hello Stefan, > > > > On 15-06-24 11:56:14, Stefan Wahren wrote: > >> Hi Sanchayan, > >> > >> Am 24.06.2015 um 07:19 schrieb maitysancha...@gmail.com: > >>> On

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Stefan Wahren
Hi Srinivas, Am 24.06.2015 um 12:45 schrieb maitysancha...@gmail.com: > Hello Stefan, > > On 15-06-24 11:56:14, Stefan Wahren wrote: >> Hi Sanchayan, >> >> Am 24.06.2015 um 07:19 schrieb maitysancha...@gmail.com: >>> On 15-06-23 21:31:41, Stefan Wahren wrote: Hi Sanchayan, > Sanchaya

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Stefan Agner
On 2015-06-24 11:56, Stefan Wahren wrote: > Hi Sanchayan, > > Am 24.06.2015 um 07:19 schrieb maitysancha...@gmail.com: >> On 15-06-23 21:31:41, Stefan Wahren wrote: >>> Hi Sanchayan, >>> Sanchayan Maity hat am 23. Juni 2015 um 15:44 geschrieben: The patch adds support for

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread maitysanchayan
Hello Stefan, On 15-06-24 11:56:14, Stefan Wahren wrote: > Hi Sanchayan, > > Am 24.06.2015 um 07:19 schrieb maitysancha...@gmail.com: > > On 15-06-23 21:31:41, Stefan Wahren wrote: > >> Hi Sanchayan, > >> > >>> Sanchayan Maity hat am 23. Juni 2015 um 15:44 > >>> geschrieben: > >>> > >>> > >>> Th

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Stefan Wahren
Hi Sanchayan, Am 24.06.2015 um 07:19 schrieb maitysancha...@gmail.com: > On 15-06-23 21:31:41, Stefan Wahren wrote: >> Hi Sanchayan, >> >>> Sanchayan Maity hat am 23. Juni 2015 um 15:44 >>> geschrieben: >>> >>> >>> The patch adds support for the On Chip One Time Programmable Peripheral >>> (OCOTP

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Sanchayan Maity
On 15-06-24 10:37:43, Srinivas Kandagatla wrote: > > > On 24/06/15 06:19, maitysancha...@gmail.com wrote: > >I just tested it without the "select REGMAP_MMIO" and it works just fine. > You just got lucky in this case, as REGMAP_MMIO is getting selected > somewhere else. > > Drivers should direct

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Srinivas Kandagatla
On 24/06/15 06:19, maitysancha...@gmail.com wrote: I just tested it without the "select REGMAP_MMIO" and it works just fine. You just got lucky in this case, as REGMAP_MMIO is getting selected somewhere else. Drivers should directly select the dependecies. In this case this driver actually

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Srinivas Kandagatla
On 24/06/15 09:35, Maxime Ripard wrote: Hi, On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote: +static struct nvmem_config ocotp_config = { + .name = "soc_id", +}; + +static struct nvmem_config rom_config = { + .name = "rom_rev", +}; Srinivas, shouldn't we use the

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-24 Thread Maxime Ripard
Hi, On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote: > +static struct nvmem_config ocotp_config = { > + .name = "soc_id", > +}; > + > +static struct nvmem_config rom_config = { > + .name = "rom_rev", > +}; Srinivas, shouldn't we use the DT to setup these names, just like

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-23 Thread maitysanchayan
Hello Srinivas, On 15-06-23 20:03:31, Srinivas Kandagatla wrote: > Hi Sanchayan, > > > On 23/06/15 14:44, Sanchayan Maity wrote: > >The patch adds support for the On Chip One Time Programmable Peripheral > >(OCOTP) and On Chip ROM (OCROM) support. > > > >On Vybrid OCOTP contain data like SoC ID,

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-23 Thread maitysanchayan
On 15-06-23 21:31:41, Stefan Wahren wrote: > Hi Sanchayan, > > > Sanchayan Maity hat am 23. Juni 2015 um 15:44 > > geschrieben: > > > > > > The patch adds support for the On Chip One Time Programmable Peripheral > > (OCOTP) and On Chip ROM (OCROM) support. > > > > On Vybrid OCOTP contain data lik

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-23 Thread Stefan Wahren
Hi Sanchayan, > Sanchayan Maity hat am 23. Juni 2015 um 15:44 > geschrieben: > > > The patch adds support for the On Chip One Time Programmable Peripheral > (OCOTP) and On Chip ROM (OCROM) support. > > On Vybrid OCOTP contain data like SoC ID, MAC address and OCROM has the > revision ID. > > Sign

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-23 Thread Srinivas Kandagatla
Hi Sanchayan, On 23/06/15 14:44, Sanchayan Maity wrote: The patch adds support for the On Chip One Time Programmable Peripheral (OCOTP) and On Chip ROM (OCROM) support. On Vybrid OCOTP contain data like SoC ID, MAC address and OCROM has the revision ID. Signed-off-by: Sanchayan Maity --- d

[RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

2015-06-23 Thread Sanchayan Maity
The patch adds support for the On Chip One Time Programmable Peripheral (OCOTP) and On Chip ROM (OCROM) support. On Vybrid OCOTP contain data like SoC ID, MAC address and OCROM has the revision ID. Signed-off-by: Sanchayan Maity --- drivers/nvmem/Kconfig | 11 + drivers/nvmem/Make