Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-05-07 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, May 07, 2019 at 09:45:47AM -0700, Alexei Starovoitov wrote: > > On Wed, Apr 24, 2019 at 5:52 AM Peter Zijlstra wrote: > > > > > > On Wed, Apr 24, 2019 at 08:42:40AM -0400, Kairui Song wrote: > > > > > > > Sure, the updated comments looks much better. Will the

Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-05-07 Thread Peter Zijlstra
On Tue, May 07, 2019 at 09:45:47AM -0700, Alexei Starovoitov wrote: > On Wed, Apr 24, 2019 at 5:52 AM Peter Zijlstra wrote: > > > > On Wed, Apr 24, 2019 at 08:42:40AM -0400, Kairui Song wrote: > > > > > Sure, the updated comments looks much better. Will the maintainer > > > squash the comment upda

Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-05-07 Thread Alexei Starovoitov
On Wed, Apr 24, 2019 at 5:52 AM Peter Zijlstra wrote: > > On Wed, Apr 24, 2019 at 08:42:40AM -0400, Kairui Song wrote: > > > Sure, the updated comments looks much better. Will the maintainer > > squash the comment update or should I send a V5? > > I've squashed it, I've just not gotten around to s

Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-24 Thread Peter Zijlstra
On Wed, Apr 24, 2019 at 08:42:40AM -0400, Kairui Song wrote: > Sure, the updated comments looks much better. Will the maintainer > squash the comment update or should I send a V5? I've squashed it, I've just not gotten around to stuffing it a git tree yet. Should happen 'soon'.

Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-24 Thread Kairui Song
On Tue, Apr 23, 2019 at 7:35 AM Peter Zijlstra wrote: > > On Tue, Apr 23, 2019 at 12:26:52AM +0800, Kairui Song wrote: > > Currently perf callchain doesn't work well with ORC unwinder > > when sampling from trace point. We'll get useless in kernel callchain > > like this: > > > > perf 6429 [000]

Re: [RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 12:26:52AM +0800, Kairui Song wrote: > Currently perf callchain doesn't work well with ORC unwinder > when sampling from trace point. We'll get useless in kernel callchain > like this: > > perf 6429 [000]22.498450: kmem:mm_page_alloc: page=0x176a17 > pfn=1

[RFC PATCH v4] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-22 Thread Kairui Song
Currently perf callchain doesn't work well with ORC unwinder when sampling from trace point. We'll get useless in kernel callchain like this: perf 6429 [000]22.498450: kmem:mm_page_alloc: page=0x176a17 pfn=1534487 order=0 migratetype=0 gfp_flags=GFP_KERNEL be23e32e __