Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-10-10 Thread Kees Cook
On Wed, Oct 09, 2019 at 01:59:13PM +0100, Dave Martin wrote: > On Fri, Aug 30, 2019 at 09:34:17AM +0100, Dave Martin wrote: > > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > > > > ELF program properties will needed fo

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-10-09 Thread Dave Martin
On Fri, Aug 30, 2019 at 09:34:17AM +0100, Dave Martin wrote: > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > > > ELF program properties will needed for detecting whether to enable > > > optional architecture or ABI feat

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-05 Thread Dave Martin
On Wed, Sep 04, 2019 at 05:50:06PM +0100, Kees Cook wrote: > On Fri, Aug 30, 2019 at 09:34:18AM +0100, Dave Martin wrote: > > Do you have any thoughts on Yu-Cheng Yu's comments? It would be nice to > > early-terminate the scan if we can, but my feeling so far was that the > > scan is cheap, the nu

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-04 Thread Kees Cook
On Fri, Aug 30, 2019 at 09:34:18AM +0100, Dave Martin wrote: > Do you have any thoughts on Yu-Cheng Yu's comments? It would be nice to > early-terminate the scan if we can, but my feeling so far was that the > scan is cheap, the number of properties is unlikely to be more than a > smallish integer

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-04 Thread Dave Martin
[Kees, you have any thoughts on the error code issue? See below.] On Tue, Sep 03, 2019 at 11:29:10PM +0100, Yu-cheng Yu wrote: > On Mon, 2019-09-02 at 10:28 +0100, Dave Martin wrote: > > On Fri, Aug 30, 2019 at 06:03:27PM +0100, Yu-cheng Yu wrote: > > > On Fri, 2019-08-30 at 09:34 +0100, Dave Mar

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-03 Thread Yu-cheng Yu
On Mon, 2019-09-02 at 10:28 +0100, Dave Martin wrote: > On Fri, Aug 30, 2019 at 06:03:27PM +0100, Yu-cheng Yu wrote: > > On Fri, 2019-08-30 at 09:34 +0100, Dave Martin wrote: > > > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Mart

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-09-02 Thread Dave Martin
On Fri, Aug 30, 2019 at 06:03:27PM +0100, Yu-cheng Yu wrote: > On Fri, 2019-08-30 at 09:34 +0100, Dave Martin wrote: > > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > > > > ELF program properties will needed for detec

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-08-30 Thread Yu-cheng Yu
On Fri, 2019-08-30 at 09:34 +0100, Dave Martin wrote: > On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > > > ELF program properties will needed for detecting whether to enable > > > optional architecture or ABI features fo

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-08-30 Thread Dave Martin
On Fri, Aug 30, 2019 at 06:37:45AM +0100, Kees Cook wrote: > On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > > ELF program properties will needed for detecting whether to enable > > optional architecture or ABI features for a new ELF process. > > > > For now, there are no generic pr

Re: [RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-08-29 Thread Kees Cook
On Fri, Aug 23, 2019 at 06:23:40PM +0100, Dave Martin wrote: > ELF program properties will needed for detecting whether to enable > optional architecture or ABI features for a new ELF process. > > For now, there are no generic properties that we care about, so do > nothing unless CONFIG_ARCH_USE_G

[RFC PATCH v2 2/2] ELF: Add ELF program property parsing support

2019-08-23 Thread Dave Martin
ELF program properties will needed for detecting whether to enable optional architecture or ABI features for a new ELF process. For now, there are no generic properties that we care about, so do nothing unless CONFIG_ARCH_USE_GNU_PROPERTY=y. Otherwise, the presence of properties using the PT_PROG