Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-27 Thread Kees Cook
On Sat, Nov 24, 2018 at 8:10 PM, Dmitry V. Levin wrote: > On Fri, Nov 23, 2018 at 07:01:39AM +0300, Dmitry V. Levin wrote: >> On Thu, Nov 22, 2018 at 04:19:10PM -0800, Andy Lutomirski wrote: >> > On Thu, Nov 22, 2018 at 11:15 AM Dmitry V. Levin wrote: >> > > On Thu, Nov 22, 2018 at 06:55:29AM -080

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-24 Thread Dmitry V. Levin
On Fri, Nov 23, 2018 at 07:01:39AM +0300, Dmitry V. Levin wrote: > On Thu, Nov 22, 2018 at 04:19:10PM -0800, Andy Lutomirski wrote: > > On Thu, Nov 22, 2018 at 11:15 AM Dmitry V. Levin wrote: > > > On Thu, Nov 22, 2018 at 06:55:29AM -0800, Andy Lutomirski wrote: > > > > On Wed, Nov 21, 2018 at 3:56

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-22 Thread Dmitry V. Levin
On Thu, Nov 22, 2018 at 04:19:10PM -0800, Andy Lutomirski wrote: > On Thu, Nov 22, 2018 at 11:15 AM Dmitry V. Levin wrote: > > > > On Thu, Nov 22, 2018 at 06:55:29AM -0800, Andy Lutomirski wrote: > > > On Wed, Nov 21, 2018 at 3:56 PM Dmitry V. Levin wrote: > > > > On Wed, Nov 21, 2018 at 02:56:57P

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-22 Thread Andy Lutomirski
On Thu, Nov 22, 2018 at 11:15 AM Dmitry V. Levin wrote: > > On Thu, Nov 22, 2018 at 06:55:29AM -0800, Andy Lutomirski wrote: > > On Wed, Nov 21, 2018 at 3:56 PM Dmitry V. Levin wrote: > > > On Wed, Nov 21, 2018 at 02:56:57PM -0800, Andy Lutomirski wrote: > > > > Please cc linux-...@vger.kernel.org

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-22 Thread Dmitry V. Levin
On Thu, Nov 22, 2018 at 06:55:29AM -0800, Andy Lutomirski wrote: > On Wed, Nov 21, 2018 at 3:56 PM Dmitry V. Levin wrote: > > On Wed, Nov 21, 2018 at 02:56:57PM -0800, Andy Lutomirski wrote: > > > Please cc linux-...@vger.kernel.org for future versions. > > > > > > On Wed, Nov 21, 2018 at 7:58 AM E

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-22 Thread Andy Lutomirski
On Wed, Nov 21, 2018 at 3:56 PM Dmitry V. Levin wrote: > > On Wed, Nov 21, 2018 at 02:56:57PM -0800, Andy Lutomirski wrote: > > Please cc linux-...@vger.kernel.org for future versions. > > > > On Wed, Nov 21, 2018 at 7:58 AM Elvira Khabirova wrote: > > > > > > struct ptrace_syscall_info { > > >

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-21 Thread Dmitry V. Levin
On Wed, Nov 21, 2018 at 02:56:57PM -0800, Andy Lutomirski wrote: > Please cc linux-...@vger.kernel.org for future versions. > > On Wed, Nov 21, 2018 at 7:58 AM Elvira Khabirova wrote: > > > > struct ptrace_syscall_info { > > __u8 op; /* 0 for entry, 1 for exit */ > > Can you add proper de

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-21 Thread Andy Lutomirski
Please cc linux-...@vger.kernel.org for future versions. On Wed, Nov 21, 2018 at 7:58 AM Elvira Khabirova wrote: > > struct ptrace_syscall_info { > __u8 op; /* 0 for entry, 1 for exit */ Can you add proper defines, like: #define PTRACE_SYSCALL_ENTRY 0 #define PTRACE_SYSCALL_EXIT 1 #defi

[RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-21 Thread Elvira Khabirova
PTRACE_GET_SYSCALL_INFO lets ptracer obtain details of the syscall the tracee is blocked in. The request returns meaningful data only when the tracee is in a syscall-enter-stop or a syscall-exit-stop. There are two reasons for a special syscall-related ptrace request. Firstly, with the current p