Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-31 Thread Borislav Petkov
On Thu, Jul 31, 2014 at 03:52:34AM -0400, Chen, Gong wrote: > I'm silly. You are right. I will use your patch directly(I should do > it at the beginning :-)). I think it is still ok that we talked about this, it can easily be gotten wrong. -- Regards/Gruss, Boris. Sent from a fat crate unde

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-31 Thread Chen, Gong
l.dk, > jbottom...@parallels.com, ne...@suse.de, christoffer.d...@linaro.org, > rost...@goodmis.org, r...@kernel.org, gre...@linuxfoundation.org, > mho...@suse.cz, da...@fromorbit.com > Subject: Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup > User-Agent: Mutt/1.5.23 (20

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-30 Thread Borislav Petkov
On Wed, Jul 30, 2014 at 02:24:15AM -0400, Chen, Gong wrote: > On Wed, Jul 23, 2014 at 10:36:28PM +0200, Borislav Petkov wrote: > > /* > >* At CPU state changes, update the x2apic cluster sibling info. > >*/ > > @@ -151,9 +166,14 @@ static int > > update_clusterinfo(struct notifier_block

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-29 Thread Chen, Gong
On Wed, Jul 23, 2014 at 10:36:28PM +0200, Borislav Petkov wrote: > /* >* At CPU state changes, update the x2apic cluster sibling info. >*/ > @@ -151,9 +166,14 @@ static int > update_clusterinfo(struct notifier_block *nfb, unsigned long action, void > *hcpu) > { > unsigned int thi

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-29 Thread Chen, Gong
On Tue, Jul 29, 2014 at 10:44:33AM +0200, Borislav Petkov wrote: > > switch (action) { > > case CPU_UP_PREPARE: > > if (!zalloc_cpumask_var(&per_cpu(cpus_in_cluster, this_cpu), > > - GFP_KERNEL)) { > > + GFP_KER

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-29 Thread Borislav Petkov
On Mon, Jul 28, 2014 at 02:04:55AM -0400, Chen, Gong wrote: > On Wed, Jul 23, 2014 at 10:36:28PM +0200, Borislav Petkov wrote: > > Those checks dealing with CPU_TASKS_FROZEN in-between make the whole > > switch statement hard to follow. > > > > How about we go a step further and deal with CPU_UP_C

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-27 Thread Chen, Gong
On Wed, Jul 23, 2014 at 10:36:28PM +0200, Borislav Petkov wrote: > Those checks dealing with CPU_TASKS_FROZEN in-between make the whole > switch statement hard to follow. > > How about we go a step further and deal with CPU_UP_CANCELED_FROZEN > upfront and even simplify the rest: > 8<---

Re: [RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-23 Thread Borislav Petkov
On Tue, Jul 22, 2014 at 09:58:49PM -0400, Chen, Gong wrote: > Remove XXX_FROZEN state from x86/x2apic_cluster. > > Signed-off-by: Chen, Gong > --- > arch/x86/kernel/apic/x2apic_cluster.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/apic/x2

[RFC PATCH v1 13/70] x86, x2apic_cluster: _FROZEN Cleanup

2014-07-22 Thread Chen, Gong
Remove XXX_FROZEN state from x86/x2apic_cluster. Signed-off-by: Chen, Gong --- arch/x86/kernel/apic/x2apic_cluster.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c index e66766b..bfd23